Updates plugins to use the Catalog and Bindings interfaces #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCHowell
force-pushed
the
v1-metadata-plugins
branch
from
98b9bd8 to
7adc8a3
Compare
17 tasks
alancai98
approved these changes
Jul 9, 2024
| ?: error("Catalog $catalogName is not registered in the MemoryPlugin") | ||
| return MemoryConnector(catalog) | ||
| override fun create(config: StructElement): Connector { | ||
| TODO("Instantiation of a MemoryConnector via the factory is currently not supported") |
There was a problem hiding this comment.
Will creation of a MemoryConnector be supported in a subsequent PR as part of #1496?
There was a problem hiding this comment.
Yes. It's required for conformance testing.
|
|
||
| public fun createTable(table: MemoryTable): Builder = apply { tables[table.getName()] = table } | ||
|
|
||
| public fun build(): MemoryConnector = MemoryConnector(name!!, tables) |
There was a problem hiding this comment.
nit: even though this is meant for internal testing, can first check that name is not null.
| * Implement [Bindings] over the tables map. | ||
| */ | ||
| private val bindings = object : Bindings { | ||
| override fun getBindings(name: String): Bindings? = null |
There was a problem hiding this comment.
perhaps should be a TODO rather than returning null?
|
|
||
| override fun getTable(name: Name): Table? { | ||
| if (name.hasNamespace()) { | ||
| error("MemoryCatalog does not support namespaces") |
There was a problem hiding this comment.
Is MemoryCatalog something that will be added in a subsequent PR? Or should this refer to MemoryConnector's catalog:
Suggested change
| error("MemoryCatalog does not support namespaces") | |
| error("MemoryConnector's Catalog does not support namespaces") |
Comment on lines
+9
to
+18
| val catalog = MemoryCatalog.builder() | ||
| .name("hello") | ||
| .defineTable("pi", MemoryTable( | ||
| type = PType.typeFloat32(), | ||
| data = ionFloat(3.14), | ||
| )) | ||
| .build() | ||
|
|
||
| // create a connector to be used in a session | ||
| val connector = MemoryConnector.from(catalog) |
There was a problem hiding this comment.
nit: code snippet slightly out of date. guess we can update after all the APIs are more finalized
- MemoryCatalog -> MemoryConnector
- MemoryTable(...) -> MemoryTable.of()
- data should be of type
Datum - MemoryConnector.from() does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
#1496
Description
This updates the our plugins to be based on the catalog interface defined in partiql-planner. It flips the dependency from planner->spi to be spi->planner.
Other Information
and Code Style Guidelines? YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.