Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix published jars for non-shadowed packages #1504

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

alancai98
Copy link
Member

@alancai98 alancai98 commented Jul 10, 2024

Relevant Issues

  • None

Description

  • Fixes the publishing of jars for non-shadowed packages. Previously, all the packages that don't shadow any packages would fatjar all the dependencies (e.g. kotlin, ion-element). With this change, we now exclude those dependencies, so the jar contains what was there previously.
  • Previous packages that shadowed certain dependencies (i.e. partiql-parser and partiql-lang-kotlin) did not have this issue
  • Testing
    • Ran publishToMavenLocal and compared the jars between 0.14.5 and this version
    • Published jars for this version do not have the extra dependencies and retain the existing APIs

Other Information

  • Updated Unreleased Section in CHANGELOG: [NO] No api changes.

  • Any backward-incompatible changes? [NO]

  • Any new external dependencies? [NO]

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

Conformance comparison report

Base (0066d2a) 8e5c6d8 +/-
% Passing 92.54% 92.54% 0.00%
✅ Passing 5384 5384 0
❌ Failing 434 434 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (0066d2a) but now fail: 0

Number failing in Base (0066d2a) but now pass: 0

Copy link
Contributor

@yliuuuu yliuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the patch removed the unshadowed dependencies in the fat jar.

Thanks for the quick fix.

@alancai98 alancai98 merged commit 55a27e6 into v0.14.6 Jul 10, 2024
10 checks passed
@alancai98 alancai98 deleted the fix-jars-for-non-shaded branch July 10, 2024 17:26
alancai98 added a commit that referenced this pull request Jul 10, 2024
))

* Fix published jars for non-shadowed packages

(cherry picked from commit 6b49fc1)

* Apply patch for partiql-eval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants