Updates rules for variable resolution #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for casting from dynamic Updates tests to give greater visibility into errors
johnedquinn
force-pushed
the
v1-conformance-variable-resolution
branch
from
304514e to
e25056c
Compare
RCHowell
requested changes
Jul 15, 2024
partiql-planner/src/main/kotlin/org/partiql/planner/internal/typer/TypeEnv.kt
Outdated
Show resolved
Hide resolved
partiql-planner/src/main/kotlin/org/partiql/planner/internal/typer/TypeEnv.kt
Outdated
Show resolved
Hide resolved
Renames Scope to Strategy Initializes TypeEnv to represent both locals and globals
I performed a minimal update by renaming TypeEnv to an internal Scope (representing locals). Renamed internal Scope to Strategy. And I created a new internal class called TypeEnv that wraps both locals and globals. Since everything is internal, we can change the name as we see fit. |
RCHowell
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other Information
and Code Style Guidelines? YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.