Fixes function invocation for missing arguments

[johnedquinn]

Description

• Fixes function invocation for missing arguments and fixes evaluation of Rex.Op.Missing.

Other Information

• Updated Unreleased Section in CHANGELOG: NO
• Any backward-incompatible changes? NO
• Any new external dependencies? NO
• Do your changes comply with the Contributing Guidelines
  and Code Style Guidelines? YES

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[yliuuuu]

I understand this PR is for evaluator only.

Curious about your thoughts on whether we should also fix the planer. i.e, The Planner is operating under signal mode, will turn 1 + MISSING in to an rexOpErr.

[johnedquinn]

I understand this PR is for evaluator only.

Curious about your thoughts on whether we should also fix the planer. i.e, The Planner is operating under signal mode, will turn 1 + MISSING in to an rexOpErr.

Just checked to be sure, always missing arguments currently returns a Rex.Op.Missing.

[yliuuuu]

The conversion happens when we convert the internal plan to public plan.

i.e.,

partiql-lang-kotlin/partiql-planner/src/main/kotlin/org/partiql/planner/internal/transforms/PlanTransform.kt

Lines 259 to 272 in b5c596c

	override fun visitRexOpMissing(node: Rex.Op.Missing, ctx: Unit): PlanNode {
	// gather problem from subtree.
	val trace = node.causes.map { visitRexOp(it, ctx) }
	return when (signalMode) {
	true -> {
	onProblem.invoke(ProblemGenerator.asError(node.problem))
	rexOpErr(node.problem.toString(), trace)
	}
	false -> {
	onProblem.invoke(ProblemGenerator.asWarning(node.problem))
	org.partiql.plan.rexOpMissing(node.problem.toString(), trace)
	}
	}
	}