-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 roll back ddl #1525
V1 roll back ddl #1525
Conversation
Conformance comparison report-Cross Engine
Number failing in both: 182 Number passing in legacy engine but fail in eval engine: 255 Number failing in legacy engine but pass in eval engine: 259 Conformance comparison report-Cross Commit-LEGACY
Number failing in both: 441 Number passing in Base (ee6c814) but now fail: 0 Number failing in Base (ee6c814) but now pass: 0 Conformance comparison report-Cross Commit-EVAL
Number failing in both: 435 Number passing in Base (ee6c814) but now fail: 3 Number failing in Base (ee6c814) but now pass: 1 Click here to see
Click here to see
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert looks good. Was not able to add a comment directly to test/partiql-tests
but I think it should still point to v1
's current commit, https://github.com/partiql/partiql-tests/tree/26ab08ec49b889550ecca4878e2a338a712dcf35.
Also in a comment or PR description, could be helpful to add:
- the branch where the new DDL changes will live before we merge it back to
v1
- information that the legacy DDL modeling in the AST and parser will be deprecated in release pre-
v1
and deleted inv1
That way when we come back to merging the DDL changes back tov1
, we're clear on the process we'll take.
Relevant Issues
Description
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
Any backward-incompatible changes? [YES/NO]
errors for users that are using our public APIs or the entities that have
public
visibility in our code-base. >Any new external dependencies? [YES/NO]
No.
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
Yes.
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.