Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 roll back ddl #1525

Merged
merged 6 commits into from
Jul 26, 2024
Merged

V1 roll back ddl #1525

merged 6 commits into from
Jul 26, 2024

Conversation

yliuuuu
Copy link
Contributor

@yliuuuu yliuuuu commented Jul 25, 2024

Relevant Issues

  • [Closes/Related To] Issue #XXX

Description

  • Roll back new CREATE Syntax Parsing support.
  • The plan is to add those back on either just before or right after v1 launch.
  • The goal is to use this as an opportunity to check if we can add a major feature addition without releasing a new major version(breaking customer).
  • The new DDL modeling lives under feature branch v1-ddl.
  • The legacy DDL AST and parser implementation will be deprecated and removed in pre-v1 release, and will be deleted in V1 release.

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]

    • No.
  • Any backward-incompatible changes? [YES/NO]

    • No.
      errors for users that are using our public APIs or the entities that have public visibility in our code-base. >
  • Any new external dependencies? [YES/NO]

    • < If YES, which ones and why? >
    • < In addition, please also mention any other alternatives you've considered and the reason they've been discarded >
      No.
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]

Yes.

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yliuuuu yliuuuu requested a review from alancai98 July 25, 2024 23:21
@yliuuuu yliuuuu marked this pull request as ready for review July 25, 2024 23:21
Copy link

github-actions bot commented Jul 25, 2024

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.49% 92.56% 0.07%
✅ Passing 5433 5438 5
❌ Failing 441 437 -4
🔶 Ignored 0 0 0
Total Tests 5874 5875 1
Number passing in both: 5179

Number failing in both: 182

Number passing in legacy engine but fail in eval engine: 255

Number failing in legacy engine but pass in eval engine: 259
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
259 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass.
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (ee6c814) fb13571 +/-
% Passing 92.49% 92.49% 0.00%
✅ Passing 5433 5433 0
❌ Failing 441 441 0
🔶 Ignored 0 0 0
Total Tests 5874 5874 0
Number passing in both: 5433

Number failing in both: 441

Number passing in Base (ee6c814) but now fail: 0

Number failing in Base (ee6c814) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

Base (ee6c814) fb13571 +/-
% Passing 92.60% 92.56% -0.03%
✅ Passing 5440 5438 -2
❌ Failing 435 437 2
🔶 Ignored 0 0 0
Total Tests 5875 5875 0
Number passing in both: 5438

Number failing in both: 435

Number passing in Base (ee6c814) but now fail: 3

Number failing in Base (ee6c814) but now pass: 1
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • equiv tupleunion with select list, compileOption: PERMISSIVE
  • equiv tupleunion with select list, compileOption: LEGACY
  • Example 6 — Value Coercion, compileOption: LEGACY
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:
Click here to see
  • Example 6 — Value Coercion, compileOption: LEGACY

Copy link
Member

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert looks good. Was not able to add a comment directly to test/partiql-tests but I think it should still point to v1's current commit, https://github.com/partiql/partiql-tests/tree/26ab08ec49b889550ecca4878e2a338a712dcf35.

Also in a comment or PR description, could be helpful to add:

  • the branch where the new DDL changes will live before we merge it back to v1
  • information that the legacy DDL modeling in the AST and parser will be deprecated in release pre-v1 and deleted in v1
    That way when we come back to merging the DDL changes back to v1, we're clear on the process we'll take.

@yliuuuu yliuuuu merged commit 26d5fd3 into v1 Jul 26, 2024
14 checks passed
@yliuuuu yliuuuu deleted the v1-roll-back-ddl branch July 26, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants