-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify functions in preparation for PartiQL-PATH #1530
Conversation
Conformance comparison report-Cross Engine
Number failing in both: 79 Number passing in legacy engine but fail in eval engine: 259 Number failing in legacy engine but pass in eval engine: 361 Conformance comparison report-Cross Commit-LEGACY
Number failing in both: 440 Number passing in Base (26d5fd3) but now fail: 0 Number failing in Base (26d5fd3) but now pass: 0 Conformance comparison report-Cross Commit-EVAL
Number failing in both: 338 Number passing in Base (26d5fd3) but now fail: 1 Number failing in Base (26d5fd3) but now pass: 1 Click here to see
Click here to see
|
internal fun PartiQLValue.isUnknown(): Boolean = this.type == PartiQLValueType.MISSING || this.isNull | ||
internal fun PartiQLValue.isUnknown(): Boolean = this.type == PartiQLValueType.ANY || this.isNull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ANY?
partiql-planner/src/main/kotlin/org/partiql/planner/internal/fn/builtins/FnIsNull.kt
Outdated
Show resolved
Hide resolved
partiql-planner/src/main/kotlin/org/partiql/planner/internal/fn/builtins/FnEq.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 31 conformance tests now failing -- potentially due to the use of ANY here.
I likely just pulled the Fns from an older v1 commit. Let me get the latest definitions. |
Relevant Issues
#1496
Description
This PR simplifies functions in SPI in preparation for the SQL-PATH. This is being done in conjunction with the PartiQL-Environment where connectors will be implemented on top of the catalog interfaces. This is an intermediate step towards the final state.
Other Information
and Code Style Guidelines? Yes
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.