Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify functions in preparation for PartiQL-PATH #1530

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Conversation

RCHowell
Copy link
Member

@RCHowell RCHowell commented Jul 29, 2024

Relevant Issues

#1496

Description

This PR simplifies functions in SPI in preparation for the SQL-PATH. This is being done in conjunction with the PartiQL-Environment where connectors will be implemented on top of the catalog interfaces. This is an intermediate step towards the final state.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RCHowell RCHowell requested a review from johnedquinn July 29, 2024 17:55
Copy link

github-actions bot commented Jul 29, 2024

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.51% 94.25% 1.74%
✅ Passing 5434 5537 103
❌ Failing 440 338 -102
🔶 Ignored 0 0 0
Total Tests 5874 5875 1
Number passing in both: 5176

Number failing in both: 79

Number passing in legacy engine but fail in eval engine: 259

Number failing in legacy engine but pass in eval engine: 361
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
361 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass.
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (26d5fd3) bda6246 +/-
% Passing 92.51% 92.51% 0.00%
✅ Passing 5434 5434 0
❌ Failing 440 440 0
🔶 Ignored 0 0 0
Total Tests 5874 5874 0
Number passing in both: 5434

Number failing in both: 440

Number passing in Base (26d5fd3) but now fail: 0

Number failing in Base (26d5fd3) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

Base (26d5fd3) bda6246 +/-
% Passing 94.25% 94.25% 0.00%
✅ Passing 5537 5537 0
❌ Failing 338 338 0
🔶 Ignored 0 0 0
Total Tests 5875 5875 0
Number passing in both: 5537

Number failing in both: 338

Number passing in Base (26d5fd3) but now fail: 1

Number failing in Base (26d5fd3) but now pass: 1
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • Example 6 — Value Coercion, compileOption: LEGACY
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:
Click here to see
  • Example 6 — Value Coercion, compileOption: LEGACY

Comment on lines 133 to 131
internal fun PartiQLValue.isUnknown(): Boolean = this.type == PartiQLValueType.MISSING || this.isNull
internal fun PartiQLValue.isUnknown(): Boolean = this.type == PartiQLValueType.ANY || this.isNull
Copy link
Member

@johnedquinn johnedquinn Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ANY?

Copy link
Member

@johnedquinn johnedquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 31 conformance tests now failing -- potentially due to the use of ANY here.

@RCHowell
Copy link
Member Author

I likely just pulled the Fns from an older v1 commit. Let me get the latest definitions.

@RCHowell RCHowell changed the title Internalizes functions from the SPI package to the planner package. Simplify functions in preparation for PartiQL-PATH Jul 31, 2024
@johnedquinn johnedquinn merged commit ad129fd into v1 Jul 31, 2024
14 checks passed
@RCHowell RCHowell deleted the v1-function branch July 31, 2024 18:11
@RCHowell RCHowell mentioned this pull request Jul 31, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants