Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Removes PartiQLValue from the planner #1594

Draft
wants to merge 3 commits into
base: v1
Choose a base branch
from
Draft

[DRAFT] Removes PartiQLValue from the planner #1594

wants to merge 3 commits into from

Conversation

RCHowell
Copy link
Contributor

Relevant Issues

Description

This PR removes PartiQLValue from the planner in favor of Datum – however the build is currently broken due to plan equivalence testing which I believe is the result of not having a equals defined for Datum.

I think we will need to change the wording of this because we need to check IR equivalence, no necessarily evaluation. Or perhaps the plan comparator can be a bit more clever...

The conventional use
* of {@link java.util.HashMap}, {@link java.util.HashSet}, {@link Object#hashCode()}, and
* {@link Object#equals(Object)} will not work outright with Datum to implement the before-mentioned operations due
* to requirements by the PartiQL and SQL Specifications.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant