Fixes conformance failures #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces creation of a DECIMAL_ARBITRARY with DECIMAL Fixes null-call of equals function
Fixes aggregations by specifying exact precision/scale Adds comparison operators using new modeling Adds in_collection function using new modeling Rewrites times/division/mod operators using new modeling
johnedquinn
force-pushed
the
v1-fix-decimal-failures
branch
from
836a1b3 to
8443f33
Compare
alancai98
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Nice -- looks like we're back to 50 conformance failures (prev run before the drop - https://github.com/partiql/partiql-lang-kotlin/actions/runs/11899775807). Left some minor comments. Looks good otherwise.
partiql-spi/src/main/kotlin/org/partiql/spi/function/builtins/AggAvg.kt
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/kotlin/org/partiql/spi/function/builtins/AggAvg.kt
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/kotlin/org/partiql/spi/function/builtins/FnTimes.kt
Show resolved
Hide resolved
partiql-spi/src/main/kotlin/org/partiql/spi/function/builtins/FnModulo.kt
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/kotlin/org/partiql/spi/function/builtins/DiadicComparisonOperator.kt
Outdated
Show resolved
Hide resolved
partiql-spi/src/main/kotlin/org/partiql/spi/function/builtins/FnGt.kt
Outdated
Show resolved
Hide resolved
test/partiql-tests-runner/src/test/kotlin/org/partiql/runner/io/DatumIonReader.kt
Show resolved
Hide resolved
alancai98
requested changes
Nov 26, 2024
partiql-spi/src/main/kotlin/org/partiql/spi/function/builtins/FnModulo.kt
Outdated
Show resolved
Hide resolved
Adds a shared static decimal per PR feedback
RCHowell
approved these changes
Nov 26, 2024
Comment on lines
+13
to
15
| init { | ||
| fillTable() | ||
| } |
There was a problem hiding this comment.
nit and don't change anything, but I think the pattern here is "must call super" which is fairly common and might have some annotations to compile-time enforce this, but I wouldn't change it
alancai98
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.