Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ignore this PR) Exclude planner & plan evaluator from tests for features not yet implemented #585

Conversation

dlurton
Copy link
Member

@dlurton dlurton commented Apr 29, 2022

Strangely, this somehow got marked as merged even though it has zero commits. Please ignore this PR.

Original text follows...

Originally part of #582 and based on #584 (which must be merged first), this PR primarily sets the target evaluator for all tests related to the following features to be the AST evaluator, thereby excluding the planner and plan evaluator from them. (These features are not yet on the backlog for the planner & plan evaluator.) Note that the new planner and evaluator are not in this branch yet and will be introduced in a separate pull request. There are also a few new tests that I added to provide simpler test cases for a few scenarios that were a little difficult to get working with the new planner and evaluator.

  • ORDER BY
  • GROUP BY
  • HAVING
  • Aggregate functions (SUM, MAX, MIN, etc)
  • PIVOT
  • UNPIVOT

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlurton dlurton merged commit ea26eea into physical-plan-staging-pig-domains Apr 29, 2022
@dlurton dlurton force-pushed the physical-plan-staging-pig-domains branch from b26029e to 3c583bc Compare April 29, 2022 20:28
@dlurton dlurton changed the title Exclude planner & plan evaluator from tests for features not yet implemented (0 commits?!?!) Exclude planner & plan evaluator from tests for features not yet implemented Apr 29, 2022
@dlurton dlurton changed the title (0 commits?!?!) Exclude planner & plan evaluator from tests for features not yet implemented (ignore this PR) Exclude planner & plan evaluator from tests for features not yet implemented May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant