Add FILTER_DISTINCT function. #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2022
Merged
- AST->logical - logical->resolved - lesolved->physical. Not yet integrated with anything--that will come in a future commit.
dlurton
force-pushed
the
physical-plan-staging-planner-passes
branch
from
ac6155a
to
48a003e
Compare
dlurton
force-pushed
the
physical-plan-staging-filter-distinct
branch
from
405ae74
to
befac52
Compare
jpschorr
approved these changes
May 19, 2022
|
|
||
| override fun callWithRequired(session: EvaluationSession, required: List<ExprValue>): ExprValue { | ||
| val argument = required.first() | ||
| // We cannot use a [HashSet] here because [ExprValue] does not implement .equals() and .hashCode() |
There was a problem hiding this comment.
It would be useful for PartiQL to have the equivalent of Ion Hash for use cases like this.
Base automatically changed from
physical-plan-staging-planner-passes
to
physical-plan-staging
May 19, 2022 20:51
dlurton
added a commit
that referenced
this pull request
May 27, 2022
Merges the following PRs to `main`: - #583 - #584 - #587 - #588 - #589 - #609 - #590 - #592 Also, this adds a TODO comment (ea40e4a, requested by @am357 in offline chat) and excludes `PlannerPipeline` from the new aggregate tests which were pulled in when merging from `main` and were not part of the other PRs (34025b3). By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
RCHowell
pushed a commit
that referenced
this pull request
Jun 1, 2022
Merges the following PRs to `main`: - #583 - #584 - #587 - #588 - #589 - #609 - #590 - #592 Also, this adds a TODO comment (ea40e4a, requested by @am357 in offline chat) and excludes `PlannerPipeline` from the new aggregate tests which were pulled in when merging from `main` and were not part of the other PRs (34025b3). By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
RCHowell
pushed a commit
that referenced
this pull request
Jun 1, 2022
Merges the following PRs to `main`: - #583 - #584 - #587 - #588 - #589 - #609 - #590 - #592 Also, this adds a TODO comment (ea40e4a, requested by @am357 in offline chat) and excludes `PlannerPipeline` from the new aggregate tests which were pulled in when merging from `main` and were not part of the other PRs (34025b3). By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
RCHowell
pushed a commit
that referenced
this pull request
Jun 1, 2022
Merges the following PRs to `main`: - #583 - #584 - #587 - #588 - #589 - #609 - #590 - #592 Also, this adds a TODO comment (ea40e4a, requested by @am357 in offline chat) and excludes `PlannerPipeline` from the new aggregate tests which were pulled in when merging from `main` and were not part of the other PRs (34025b3). By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally part of #582 and is based on #588, which must be merged first.
This function is used by the planner to implement
SELECT DISTINCTfunctionality.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.