Skip to content

Add boxed variant comparisons #2949

Add boxed variant comparisons

Add boxed variant comparisons #2949

Triggered via push January 4, 2025 05:44
Status Success
Total duration 6m 53s
Artifacts

coverage.yml

on: push
Matrix: Build and Test
Fit to window
Zoom out
Zoom in

Annotations

98 warnings
doc list item without indentation: partiql-conformance-tests/src/bin/generate_comparison_report.rs#L23
warning: doc list item without indentation --> partiql-conformance-tests/src/bin/generate_comparison_report.rs:23:5 | 23 | /// regressed behavior) | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 23 | /// regressed behavior) | ++
unreachable pattern: partiql-logical-planner/src/typer.rs#L348
warning: unreachable pattern --> partiql-logical-planner/src/typer.rs:348:21 | 348 | _ => { | ^ no value can reach this | note: multiple earlier patterns match some of the same values --> partiql-logical-planner/src/typer.rs:348:21 | 336 | Lit::Null | Lit::Missing => type_undefined!(), | ------------------------ matches some of the same values 337 | Lit::Int8(_) | Lit::Int16(_) | Lit::Int32(_) | Lit::Int64(_) => { | ------------------------------------------------------------ matches some of the same values ... 340 | Lit::Decimal(_) => type_decimal!(), | --------------- matches some of the same values 341 | Lit::Double(_) => type_float64!(), | -------------- matches some of the same values ... 348 | _ => { | ^ ...and 6 other patterns collectively make this unreachable = note: `#[warn(unreachable_patterns)]` on by default
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L164
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:164:13 | 163 | pub struct EvaluationFailAssertion { | ----------------------- field in this struct 164 | pub result: String, | ^^^^^^ | = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L157
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:157:13 | 156 | pub struct EvaluationSuccessAssertion { | -------------------------- field in this struct 157 | pub result: String, | ^^^^^^ | = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L152
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:152:13 | 151 | pub struct StaticAnalysisFailAssertion { | --------------------------- field in this struct 152 | pub result: String, | ^^^^^^ | = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L147
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:147:13 | 146 | pub struct SyntaxFailAssertion { | ------------------- field in this struct 147 | pub result: String, | ^^^^^^ | = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L142
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:142:13 | 141 | pub struct SyntaxSuccessAssertion { | ---------------------- field in this struct 142 | pub result: String, | ^^^^^^ | = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L75
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:75:28 | 75 | StaticAnalysisFail(StaticAnalysisFailAssertion), | ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 75 | StaticAnalysisFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L74
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:74:20 | 74 | SyntaxFail(SyntaxFailAssertion), | ---------- ^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 74 | SyntaxFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L73
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:73:23 | 73 | SyntaxSuccess(SyntaxSuccessAssertion), | ------------- ^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 73 | SyntaxSuccess(()), | ~~
unexpected `cfg` condition value: `serde`: partiql-eval/src/eval/mod.rs#L149
warning: unexpected `cfg` condition value: `serde` --> partiql-eval/src/eval/mod.rs:149:12 | 149 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ^^^^^^^^^^^^^^^^^ help: remove the condition | = note: no expected values for `feature` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default
spawned process is never `wait()`ed on: partiql-conformance-tests/build.rs#L11
warning: spawned process is never `wait()`ed on --> partiql-conformance-tests/build.rs:11:5 | 11 | / Command::new("cargo") 12 | | .arg("fmt") 13 | | .arg("--") 14 | | .spawn() 15 | | .expect("cargo fmt of tests/ failed"); | | ^- help: try: `.wait()` | |_____________________________________________| | | = note: not doing so might leave behind zombie processes = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes = note: `#[warn(clippy::zombie_processes)]` on by default
variant `Bag` is never constructed: extension/partiql-extension-ion/src/util.rs#L11
warning: variant `Bag` is never constructed --> extension/partiql-extension-ion/src/util.rs:11:5 | 8 | pub enum PartiqlValueTarget<T> { | ------------------ variant in this enum ... 11 | Bag(Vec<T>), | ^^^ | = note: `#[warn(dead_code)]` on by default
type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`: extension/partiql-extension-ion/src/boxed_ion.rs#L450
warning: type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse` --> extension/partiql-extension-ion/src/boxed_ion.rs:450:5 | 450 | pub fn parse(data: Vec<u8>, expected: BoxedIonStreamType) -> IonResult<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::parse` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonStreamType` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:522:1 | 522 | enum BoxedIonStreamType { | ^^^^^^^^^^^^^^^^^^^^^^^
type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value`: extension/partiql-extension-ion/src/boxed_ion.rs#L435
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value` --> extension/partiql-extension-ion/src/boxed_ion.rs:435:5 | 435 | pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:97:1 | 97 | struct IonContext { | ^^^^^^^^^^^^^^^^^
type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value`: extension/partiql-extension-ion/src/boxed_ion.rs#L435
warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value` --> extension/partiql-extension-ion/src/boxed_ion.rs:435:5 | 435 | pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:529:1 | 529 | enum BoxedIonValue { | ^^^^^^^^^^^^^^^^^^
type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new`: extension/partiql-extension-ion/src/boxed_ion.rs#L429
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new` --> extension/partiql-extension-ion/src/boxed_ion.rs:429:5 | 429 | pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:97:1 | 97 | struct IonContext { | ^^^^^^^^^^^^^^^^^
type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new`: extension/partiql-extension-ion/src/boxed_ion.rs#L429
warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new` --> extension/partiql-extension-ion/src/boxed_ion.rs:429:5 | 429 | pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:529:1 | 529 | enum BoxedIonValue { | ^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_bounds)]` on by default
type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr`: extension/partiql-extension-ion/src/boxed_ion.rs#L113
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr` --> extension/partiql-extension-ion/src/boxed_ion.rs:113:1 | 113 | pub type IonContextPtr = Rc<RefCell<IonContext>>; | ^^^^^^^^^^^^^^^^^^^^^^ type alias `boxed_ion::IonContextPtr` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:97:1 | 97 | struct IonContext { | ^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L406
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:406:21 | 406 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `seq`: extension/partiql-extension-ion/src/boxed_ion.rs#L392
warning: unused variable: `seq` --> extension/partiql-extension-ion/src/boxed_ion.rs:392:37 | 392 | BoxedIonValue::Sequence(seq) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_seq`
unused variable: `k`: extension/partiql-extension-ion/src/boxed_ion.rs#L381
warning: unused variable: `k` --> extension/partiql-extension-ion/src/boxed_ion.rs:381:23 | 381 | fn take_val(self, k: &BindingsName<'_>) -> Option<Value> { | ^ help: if this is intentional, prefix it with an underscore: `_k`
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L374
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:374:21 | 374 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `seq`: extension/partiql-extension-ion/src/boxed_ion.rs#L360
warning: unused variable: `seq` --> extension/partiql-extension-ion/src/boxed_ion.rs:360:37 | 360 | BoxedIonValue::Sequence(seq) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_seq`
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L346
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:346:21 | 346 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `seq`: extension/partiql-extension-ion/src/boxed_ion.rs#L341
warning: unused variable: `seq` --> extension/partiql-extension-ion/src/boxed_ion.rs:341:37 | 341 | BoxedIonValue::Sequence(seq) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_seq`
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L321
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:321:21 | 321 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L299
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:299:21 | 299 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L279
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:279:21 | 279 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `seq`: extension/partiql-extension-ion/src/boxed_ion.rs#L188
warning: unused variable: `seq` --> extension/partiql-extension-ion/src/boxed_ion.rs:188:37 | 188 | BoxedIonValue::Sequence(seq) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_seq`
unused variable: `seq`: extension/partiql-extension-ion/src/boxed_ion.rs#L168
warning: unused variable: `seq` --> extension/partiql-extension-ion/src/boxed_ion.rs:168:37 | 168 | BoxedIonValue::Sequence(seq) => DatumCategoryRef::Sequence(DatumSeqRef::Dynamic(self)), | ^^^ help: if this is intentional, prefix it with an underscore: `_seq`
unused variable: `state`: extension/partiql-extension-ion/src/boxed_ion.rs#L143
warning: unused variable: `state` --> extension/partiql-extension-ion/src/boxed_ion.rs:143:31 | 143 | fn hash<H: Hasher>(&self, state: &mut H) { | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state`
unused variable: `deserializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L134
warning: unused variable: `deserializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:134:23 | 134 | fn deserialize<D>(deserializer: D) -> std::result::Result<Self, D::Error> | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_deserializer`
unused variable: `serializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L124
warning: unused variable: `serializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:124:28 | 124 | fn serialize<S>(&self, serializer: S) -> std::result::Result<S::Ok, S::Error> | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_serializer` | = note: `#[warn(unused_variables)]` on by default
unused import: `ion_rs_old::IonReader`: extension/partiql-extension-ion/src/boxed_ion.rs#L6
warning: unused import: `ion_rs_old::IonReader` --> extension/partiql-extension-ion/src/boxed_ion.rs:6:5 | 6 | use ion_rs_old::IonReader; | ^^^^^^^^^^^^^^^^^^^^^
unused imports: `Deserialize` and `Serialize`: extension/partiql-extension-ion/src/lib.rs#L5
warning: unused imports: `Deserialize` and `Serialize` --> extension/partiql-extension-ion/src/lib.rs:5:13 | 5 | use serde::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
field `0` is never read: partiql-value/src/variant.rs#L121
warning: field `0` is never read --> partiql-value/src/variant.rs:121:28 | 121 | pub struct VariantIter<'a>(BoxedVariantValueIter<'a>); | ----------- ^^^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this struct | = help: consider removing this field = note: `#[warn(dead_code)]` on by default
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L164
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:164:13 | 163 | pub struct EvaluationFailAssertion { | ----------------------- field in this struct 164 | pub result: String, | ^^^^^^ | = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L157
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:157:13 | 156 | pub struct EvaluationSuccessAssertion { | -------------------------- field in this struct 157 | pub result: String, | ^^^^^^ | = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L152
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:152:13 | 151 | pub struct StaticAnalysisFailAssertion { | --------------------------- field in this struct 152 | pub result: String, | ^^^^^^ | = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L147
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:147:13 | 146 | pub struct SyntaxFailAssertion { | ------------------- field in this struct 147 | pub result: String, | ^^^^^^ | = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L142
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:142:13 | 141 | pub struct SyntaxSuccessAssertion { | ---------------------- field in this struct 142 | pub result: String, | ^^^^^^ | = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L75
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:75:28 | 75 | StaticAnalysisFail(StaticAnalysisFailAssertion), | ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 75 | StaticAnalysisFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L74
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:74:20 | 74 | SyntaxFail(SyntaxFailAssertion), | ---------- ^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 74 | SyntaxFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L73
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:73:23 | 73 | SyntaxSuccess(SyntaxSuccessAssertion), | ------------- ^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 73 | SyntaxSuccess(()), | ~~
unused variable: `doc`: partiql-value/src/value/iter.rs#L43
warning: unused variable: `doc` --> partiql-value/src/value/iter.rs:43:33 | 43 | ValueIter::Embedded(doc) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_doc`
unused variable: `doc`: partiql-value/src/value/iter.rs#L23
warning: unused variable: `doc` --> partiql-value/src/value/iter.rs:23:33 | 23 | ValueIter::Embedded(doc) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_doc` | = note: `#[warn(unused_variables)]` on by default
unused import: `Write`: partiql-value/src/variant.rs#L17
warning: unused import: `Write` --> partiql-value/src/variant.rs:17:34 | 17 | use std::fmt::{Debug, Formatter, Write}; | ^^^^^
unused imports: `Deserialize` and `Serialize`: partiql-value/src/lib.rs#L30
warning: unused imports: `Deserialize` and `Serialize` --> partiql-value/src/lib.rs:30:13 | 30 | use serde::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
doc list item without indentation: partiql-conformance-tests/src/bin/generate_comparison_report.rs#L23
warning: doc list item without indentation --> partiql-conformance-tests/src/bin/generate_comparison_report.rs:23:5 | 23 | /// regressed behavior) | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 23 | /// regressed behavior) | ++
unreachable pattern: partiql-logical-planner/src/typer.rs#L348
warning: unreachable pattern --> partiql-logical-planner/src/typer.rs:348:21 | 348 | _ => { | ^ no value can reach this | note: multiple earlier patterns match some of the same values --> partiql-logical-planner/src/typer.rs:348:21 | 336 | Lit::Null | Lit::Missing => type_undefined!(), | ------------------------ matches some of the same values 337 | Lit::Int8(_) | Lit::Int16(_) | Lit::Int32(_) | Lit::Int64(_) => { | ------------------------------------------------------------ matches some of the same values ... 340 | Lit::Decimal(_) => type_decimal!(), | --------------- matches some of the same values 341 | Lit::Double(_) => type_float64!(), | -------------- matches some of the same values ... 348 | _ => { | ^ ...and 6 other patterns collectively make this unreachable = note: `#[warn(unreachable_patterns)]` on by default
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L164
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:164:13 | 163 | pub struct EvaluationFailAssertion { | ----------------------- field in this struct 164 | pub result: String, | ^^^^^^ | = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L157
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:157:13 | 156 | pub struct EvaluationSuccessAssertion { | -------------------------- field in this struct 157 | pub result: String, | ^^^^^^ | = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L152
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:152:13 | 151 | pub struct StaticAnalysisFailAssertion { | --------------------------- field in this struct 152 | pub result: String, | ^^^^^^ | = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L147
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:147:13 | 146 | pub struct SyntaxFailAssertion { | ------------------- field in this struct 147 | pub result: String, | ^^^^^^ | = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L142
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:142:13 | 141 | pub struct SyntaxSuccessAssertion { | ---------------------- field in this struct 142 | pub result: String, | ^^^^^^ | = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L75
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:75:28 | 75 | StaticAnalysisFail(StaticAnalysisFailAssertion), | ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 75 | StaticAnalysisFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L74
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:74:20 | 74 | SyntaxFail(SyntaxFailAssertion), | ---------- ^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 74 | SyntaxFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L73
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:73:23 | 73 | SyntaxSuccess(SyntaxSuccessAssertion), | ------------- ^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 73 | SyntaxSuccess(()), | ~~
unexpected `cfg` condition value: `serde`: partiql-eval/src/eval/mod.rs#L149
warning: unexpected `cfg` condition value: `serde` --> partiql-eval/src/eval/mod.rs:149:12 | 149 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ^^^^^^^^^^^^^^^^^ help: remove the condition | = note: no expected values for `feature` = help: consider adding `serde` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default
spawned process is never `wait()`ed on: partiql-conformance-tests/build.rs#L11
warning: spawned process is never `wait()`ed on --> partiql-conformance-tests/build.rs:11:5 | 11 | / Command::new("cargo") 12 | | .arg("fmt") 13 | | .arg("--") 14 | | .spawn() 15 | | .expect("cargo fmt of tests/ failed"); | | ^- help: try: `.wait()` | |_____________________________________________| | | = note: not doing so might leave behind zombie processes = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes = note: `#[warn(clippy::zombie_processes)]` on by default
variant `Bag` is never constructed: extension/partiql-extension-ion/src/util.rs#L11
warning: variant `Bag` is never constructed --> extension/partiql-extension-ion/src/util.rs:11:5 | 8 | pub enum PartiqlValueTarget<T> { | ------------------ variant in this enum ... 11 | Bag(Vec<T>), | ^^^ | = note: `#[warn(dead_code)]` on by default
type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`: extension/partiql-extension-ion/src/boxed_ion.rs#L450
warning: type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse` --> extension/partiql-extension-ion/src/boxed_ion.rs:450:5 | 450 | pub fn parse(data: Vec<u8>, expected: BoxedIonStreamType) -> IonResult<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::parse` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonStreamType` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:522:1 | 522 | enum BoxedIonStreamType { | ^^^^^^^^^^^^^^^^^^^^^^^
type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value`: extension/partiql-extension-ion/src/boxed_ion.rs#L435
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value` --> extension/partiql-extension-ion/src/boxed_ion.rs:435:5 | 435 | pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:97:1 | 97 | struct IonContext { | ^^^^^^^^^^^^^^^^^
type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value`: extension/partiql-extension-ion/src/boxed_ion.rs#L435
warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value` --> extension/partiql-extension-ion/src/boxed_ion.rs:435:5 | 435 | pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:529:1 | 529 | enum BoxedIonValue { | ^^^^^^^^^^^^^^^^^^
type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new`: extension/partiql-extension-ion/src/boxed_ion.rs#L429
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new` --> extension/partiql-extension-ion/src/boxed_ion.rs:429:5 | 429 | pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:97:1 | 97 | struct IonContext { | ^^^^^^^^^^^^^^^^^
type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new`: extension/partiql-extension-ion/src/boxed_ion.rs#L429
warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new` --> extension/partiql-extension-ion/src/boxed_ion.rs:429:5 | 429 | pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:529:1 | 529 | enum BoxedIonValue { | ^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_bounds)]` on by default
type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr`: extension/partiql-extension-ion/src/boxed_ion.rs#L113
warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr` --> extension/partiql-extension-ion/src/boxed_ion.rs:113:1 | 113 | pub type IonContextPtr = Rc<RefCell<IonContext>>; | ^^^^^^^^^^^^^^^^^^^^^^ type alias `boxed_ion::IonContextPtr` is reachable at visibility `pub` | note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:97:1 | 97 | struct IonContext { | ^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L406
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:406:21 | 406 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `seq`: extension/partiql-extension-ion/src/boxed_ion.rs#L392
warning: unused variable: `seq` --> extension/partiql-extension-ion/src/boxed_ion.rs:392:37 | 392 | BoxedIonValue::Sequence(seq) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_seq`
unused variable: `k`: extension/partiql-extension-ion/src/boxed_ion.rs#L381
warning: unused variable: `k` --> extension/partiql-extension-ion/src/boxed_ion.rs:381:23 | 381 | fn take_val(self, k: &BindingsName<'_>) -> Option<Value> { | ^ help: if this is intentional, prefix it with an underscore: `_k`
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L374
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:374:21 | 374 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `seq`: extension/partiql-extension-ion/src/boxed_ion.rs#L360
warning: unused variable: `seq` --> extension/partiql-extension-ion/src/boxed_ion.rs:360:37 | 360 | BoxedIonValue::Sequence(seq) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_seq`
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L346
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:346:21 | 346 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `seq`: extension/partiql-extension-ion/src/boxed_ion.rs#L341
warning: unused variable: `seq` --> extension/partiql-extension-ion/src/boxed_ion.rs:341:37 | 341 | BoxedIonValue::Sequence(seq) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_seq`
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L321
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:321:21 | 321 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L299
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:299:21 | 299 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `e`: extension/partiql-extension-ion/src/boxed_ion.rs#L279
warning: unused variable: `e` --> extension/partiql-extension-ion/src/boxed_ion.rs:279:21 | 279 | Err(e) => todo!(), | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `seq`: extension/partiql-extension-ion/src/boxed_ion.rs#L188
warning: unused variable: `seq` --> extension/partiql-extension-ion/src/boxed_ion.rs:188:37 | 188 | BoxedIonValue::Sequence(seq) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_seq`
unused variable: `seq`: extension/partiql-extension-ion/src/boxed_ion.rs#L168
warning: unused variable: `seq` --> extension/partiql-extension-ion/src/boxed_ion.rs:168:37 | 168 | BoxedIonValue::Sequence(seq) => DatumCategoryRef::Sequence(DatumSeqRef::Dynamic(self)), | ^^^ help: if this is intentional, prefix it with an underscore: `_seq`
unused variable: `state`: extension/partiql-extension-ion/src/boxed_ion.rs#L143
warning: unused variable: `state` --> extension/partiql-extension-ion/src/boxed_ion.rs:143:31 | 143 | fn hash<H: Hasher>(&self, state: &mut H) { | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state`
unused variable: `deserializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L134
warning: unused variable: `deserializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:134:23 | 134 | fn deserialize<D>(deserializer: D) -> std::result::Result<Self, D::Error> | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_deserializer`
unused variable: `serializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L124
warning: unused variable: `serializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:124:28 | 124 | fn serialize<S>(&self, serializer: S) -> std::result::Result<S::Ok, S::Error> | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_serializer` | = note: `#[warn(unused_variables)]` on by default
unused import: `ion_rs_old::IonReader`: extension/partiql-extension-ion/src/boxed_ion.rs#L6
warning: unused import: `ion_rs_old::IonReader` --> extension/partiql-extension-ion/src/boxed_ion.rs:6:5 | 6 | use ion_rs_old::IonReader; | ^^^^^^^^^^^^^^^^^^^^^
unused imports: `Deserialize` and `Serialize`: extension/partiql-extension-ion/src/lib.rs#L5
warning: unused imports: `Deserialize` and `Serialize` --> extension/partiql-extension-ion/src/lib.rs:5:13 | 5 | use serde::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L164
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:164:13 | 163 | pub struct EvaluationFailAssertion { | ----------------------- field in this struct 164 | pub result: String, | ^^^^^^ | = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L157
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:157:13 | 156 | pub struct EvaluationSuccessAssertion { | -------------------------- field in this struct 157 | pub result: String, | ^^^^^^ | = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L152
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:152:13 | 151 | pub struct StaticAnalysisFailAssertion { | --------------------------- field in this struct 152 | pub result: String, | ^^^^^^ | = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L147
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:147:13 | 146 | pub struct SyntaxFailAssertion { | ------------------- field in this struct 147 | pub result: String, | ^^^^^^ | = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L142
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:142:13 | 141 | pub struct SyntaxSuccessAssertion { | ---------------------- field in this struct 142 | pub result: String, | ^^^^^^ | = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L75
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:75:28 | 75 | StaticAnalysisFail(StaticAnalysisFailAssertion), | ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 75 | StaticAnalysisFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L74
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:74:20 | 74 | SyntaxFail(SyntaxFailAssertion), | ---------- ^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 74 | SyntaxFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L73
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:73:23 | 73 | SyntaxSuccess(SyntaxSuccessAssertion), | ------------- ^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 73 | SyntaxSuccess(()), | ~~
field `0` is never read: partiql-value/src/variant.rs#L121
warning: field `0` is never read --> partiql-value/src/variant.rs:121:28 | 121 | pub struct VariantIter<'a>(BoxedVariantValueIter<'a>); | ----------- ^^^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this struct | = help: consider removing this field = note: `#[warn(dead_code)]` on by default
unused variable: `doc`: partiql-value/src/value/iter.rs#L43
warning: unused variable: `doc` --> partiql-value/src/value/iter.rs:43:33 | 43 | ValueIter::Embedded(doc) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_doc`
unused variable: `doc`: partiql-value/src/value/iter.rs#L23
warning: unused variable: `doc` --> partiql-value/src/value/iter.rs:23:33 | 23 | ValueIter::Embedded(doc) => { | ^^^ help: if this is intentional, prefix it with an underscore: `_doc` | = note: `#[warn(unused_variables)]` on by default
unused import: `Write`: partiql-value/src/variant.rs#L17
warning: unused import: `Write` --> partiql-value/src/variant.rs:17:34 | 17 | use std::fmt::{Debug, Formatter, Write}; | ^^^^^
unused imports: `Deserialize` and `Serialize`: partiql-value/src/lib.rs#L30
warning: unused imports: `Deserialize` and `Serialize` --> partiql-value/src/lib.rs:30:13 | 30 | use serde::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default