Skip to content

Add #![deny(rust_2018_idioms)] to all crates (#451) #2456

Add #![deny(rust_2018_idioms)] to all crates (#451)

Add #![deny(rust_2018_idioms)] to all crates (#451) #2456

Triggered via push March 13, 2024 23:08
Status Success
Total duration 7m 51s
Artifacts 1
Create conformance report for `push` and `pull_request` events
5m 44s
Create conformance report for `push` and `pull_request` events
Matrix: Build and Test
Matrix: cargo-deny
Create comparison report for `pull_request` event
0s
Create comparison report for `pull_request` event
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
Create conformance report for `push` and `pull_request` events
Process completed with exit code 101.
cargo-deny (bans licenses sources)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
cargo-deny (advisories)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: partiql-catalog/src/call_defs.rs#L34
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> partiql-catalog/src/call_defs.rs:34:15 | 34 | args: &Vec<CallArgument>, | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[CallArgument]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default
redundant pattern matching, consider using `is_some()`: /home/runner/work/partiql-lang-rust/partiql-lang-rust/target/debug/build/partiql-parser-a451281732f17441/out/partiql.rs#L47883
warning: redundant pattern matching, consider using `is_some()` --> /home/runner/work/partiql-lang-rust/partiql-lang-rust/target/debug/build/partiql-parser-a451281732f17441/out/partiql.rs:47883:25 | 47883 | let recursive = matches!(rec, Some(_)); | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `rec.is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
allow(rust_2018_idioms) is ignored unless specified at crate level: partiql-parser/src/parse/mod.rs#L30
warning: allow(rust_2018_idioms) is ignored unless specified at crate level --> partiql-parser/src/parse/mod.rs:30:9 | 30 | #[allow(rust_2018_idioms)] | ^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_attributes)]` on by default
Build and Test (ubuntu-20.04)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build and Test (ubuntu-20.04)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Create conformance report for `push` and `pull_request` events
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build and Test (macos-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build and Test (windows-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Artifacts

Produced during runtime
Name Size
artifact Expired
1010 KB