Fix clippy warnings + errors

partiql · Oct 24, 2023 · 6579cb5 · 6579cb5
1 parent f5ba355
commit 6579cb5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 18 deletions.
diff --git a/partiql-value/src/list.rs b/partiql-value/src/list.rs
@@ -183,22 +183,7 @@ impl PartialEq for List {
 
 impl PartialOrd for List {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        let mut l = self.0.iter();
-        let mut r = other.0.iter();
-
-        loop {
-            match (l.next(), r.next()) {
-                (None, None) => return Some(Ordering::Equal),
-                (Some(_), None) => return Some(Ordering::Greater),
-                (None, Some(_)) => return Some(Ordering::Less),
-                (Some(lv), Some(rv)) => match lv.partial_cmp(rv) {
-                    None => return None,
-                    Some(Ordering::Less) => return Some(Ordering::Less),
-                    Some(Ordering::Greater) => return Some(Ordering::Greater),
-                    Some(Ordering::Equal) => continue,
-                },
-            }
-        }
+        Some(self.cmp(other))
     }
 }
 

diff --git a/partiql/benches/bench_agg.rs b/partiql/benches/bench_agg.rs
@@ -115,11 +115,11 @@ fn create_tests() -> Vec<(String, String)> {
 
     let aggs_all = aggs
         .into_iter()
-        .cartesian_product([false].into_iter())
+        .cartesian_product([false])
         .collect_vec();
     let aggs_distinct = aggs
         .into_iter()
-        .cartesian_product([true].into_iter())
+        .cartesian_product([true])
         .collect_vec();
 
     let full_aggs_all = groups