Minor cleanup and formatting fixes #445
Conversation
Conformance comparison report
Number passing in both: 5731 Number failing in both: 612 Number passing in Base (05d3fc8) but now fail: 0 Number failing in Base (05d3fc8) but now pass: 0 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
+ Coverage 79.07% 79.10% +0.03%
==========================================
Files 65 65
Lines 17531 17423 -108
Branches 17531 17423 -108
==========================================
- Hits 13862 13782 -80
+ Misses 3099 3075 -24
+ Partials 570 566 -4 ☔ View full report in Codecov by Sentry. |
| @@ -118,22 +118,16 @@ impl EvalPathComponent { | |||
| impl EvalExpr for EvalPath { | |||
| fn evaluate<'a>(&'a self, bindings: &'a Tuple, ctx: &'a dyn EvalContext) -> Cow<'a, Value> { | |||
| let value = self.expr.evaluate(bindings, ctx); | |||
| let mut path_componenents = self.components.iter(); | |||
There was a problem hiding this comment.
there's a clippy warning that looks unrelated to this PR's changes on L3:
unused import:
BorrowMut
There was a problem hiding this comment.
I think that'll be fixed by the rebase over #443
jpschorr
force-pushed
the
chore-cleanup
branch
from
3ebffda to
002d679
Compare
Clippy, Format, and other small cleanup.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.