Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #![deny(clippy::all)] to all lib.rs #453

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Add #![deny(clippy::all)] to all lib.rs #453

merged 3 commits into from
Mar 15, 2024

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Mar 14, 2024

  • Add #![deny(clippy::all)] to all lib.rs
  • Apply automatic fixes from cargo clippy --fix --all-features; cargo fmt
  • Manually clean-up the ~3 clippy recommendations that automatics fixes didn't fix.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Mar 14, 2024

Conformance comparison report

Base (6d31b39) 46026fe +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (6d31b39) but now fail: 0

Number failing in Base (6d31b39) but now pass: 0

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 75.39683% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 79.25%. Comparing base (6d31b39) to head (0e6b0fc).

Files Patch % Lines
partiql-parser/src/preprocessor.rs 28.75% 0 Missing and 57 partials ⚠️
partiql-logical-planner/src/lower.rs 60.00% 8 Missing ⚠️
extension/partiql-extension-ion/src/encode.rs 76.00% 0 Missing and 6 partials ⚠️
partiql-parser/src/parse/mod.rs 96.12% 5 Missing ⚠️
partiql-catalog/src/lib.rs 0.00% 1 Missing and 3 partials ⚠️
partiql-logical-planner/src/typer.rs 71.42% 4 Missing ⚠️
partiql-ast-passes/src/partiql_typer.rs 25.00% 3 Missing ⚠️
partiql-value/src/datetime.rs 0.00% 2 Missing ⚠️
partiql-ast-passes/src/name_resolver.rs 85.71% 1 Missing ⚠️
partiql-eval/src/eval/evaluable.rs 87.50% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   79.26%   79.25%   -0.02%     
==========================================
  Files          66       66              
  Lines       17752    17765      +13     
  Branches    17752    17765      +13     
==========================================
+ Hits        14072    14080       +8     
- Misses       3110     3111       +1     
- Partials      570      574       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpschorr jpschorr changed the title Feat clippy lints Add #![deny(clippy::all)] to all lib.rs Mar 14, 2024
@jpschorr jpschorr requested review from alancai98 and am357 March 14, 2024 18:25
@jpschorr jpschorr marked this pull request as ready for review March 14, 2024 18:25
Copy link
Member

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider functions that now have the #[must_use] annotation as a breaking change?

@jpschorr jpschorr merged commit f9ea25c into main Mar 15, 2024
18 of 19 checks passed
@jpschorr jpschorr deleted the feat-clippy-lints branch September 4, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants