Remove NULL and MISSING from partiql-types
#463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are making progress towards fleshing out partiql type semantics with more details, the current informal consensus is that `NULL` and `MISSING` can only have meaning as values or constraints (E.g., `NOT NULL`); considering this, this PR removes `PartiQLType::NULL` and `PartiQLType::MISSING`. In addition, it includes the following: 1. removes unused `partiql_ast_passes::partiql_typer` 2. fixes Clippy `multiple_bound_locations` errors `partiql-eval`
Conformance comparison report
Number passing in both: 5731 Number failing in both: 612 Number passing in Base (5dc7c6e) but now fail: 0 Number failing in Base (5dc7c6e) but now pass: 0 |
am357
changed the title
NULL and MISSING from partiql-typesNULL and MISSING from partiql-types
jpschorr
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
As we are making progress towards fleshing out partiql type semantics with more details, the current informal consensus is that
NULLandMISSINGcan only have meaning as values or constraints (E.g.,NOT NULL); considering this, this PR removesPartiQLType::NULLandPartiQLType::MISSING.Important to note is, this PR, types literals
NULLandMISSINGvalues asUndefined(orUnknown). The rationale for making this experimental decision is that bothNULLandMISSINGabsent values represent no types;NULLis a property of present types rather than a type itself. E.g., in SQLNULLcan be assigned to any type of column. In addition, its presence in operations can lead toNULL. This follows SQL's Three-Valued Logic i.e., "If a null value affects the result of a logical expression, the result is neither true nor false but unknown.".One could argue that the
Unknowntype for PartiQL absent values (NULLandMISSING) is an inhabited Bottom Types.This PR also includes the following:
partiql_ast_passes::partiql_typermultiple_bound_locationserrorspartiql-evalBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.