warning: usage of `Iterator::fold` on a type that implements `Try`
   --> partiql-eval/src/eval/expr/path.rs:132:18
    |
132 |                   .fold(Some(owned), |v, path| {
    |  __________________^
133 | |                     v.and_then(|v| path.take_val(v, bindings, ctx))
134 | |                 })
    | |__________________^ help: use `try_fold` instead: `try_fold(owned, |v, path| ...)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try`
   --> partiql-eval/src/eval/expr/path.rs:125:18
    |
125 |                   .fold(Some(borrowed), |v, path| {
    |  __________________^
126 | |                     v.and_then(|v| path.get_val(v, bindings, ctx))
127 | |                 })
    | |__________________^ help: use `try_fold` instead: `try_fold(borrowed, |v, path| ...)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
    = note: `#[warn(clippy::manual_try_fold)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> partiql-logical-planner/src/lower.rs:339:42
    |
339 |                   let name_ref: &NameRef = &key_schema
    |  __________________________________________^
340 | |                     .consume
341 | |                     .iter()
342 | |                     .find(|name_ref| name_ref.sym == varref.name)
343 | |                     .expect("NameRef");
    | |______________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default
help: change this to
    |
339 ~                 let name_ref: &NameRef = key_schema
340 +                     .consume
341 +                     .iter()
342 +                     .find(|name_ref| name_ref.sym == varref.name)
343 ~                     .expect("NameRef");
    |

warning: function `binding_to_symprim` is never used
   --> partiql-logical-planner/src/lower.rs:292:12
    |
292 |         fn binding_to_symprim<'a>(binding: &'a BindingsName<'a>) -> SymbolPrimitive {
    |            ^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: unused variable: `vrtype`
   --> partiql-logical-planner/src/lower.rs:914:56
    |
914 |                         if let ValueExpr::VarRef(name, vrtype) = &value {
    |                                                        ^^^^^^ help: if this is intentional, prefix it with an underscore: `_vrtype`

warning: unused variable: `k`
   --> partiql-logical-planner/src/lower.rs:359:32
    |
359 |                         .map(|(k, v)| binding_to_static(v))
    |                                ^ help: if this is intentional, prefix it with an underscore: `_k`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: unused import: `NameLookup`
  --> partiql-logical-planner/src/lower.rs:35:41
   |
35 | use partiql_ast_passes::name_resolver::{NameLookup, NameRef};
   |                                         ^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `BorrowMut`
 --> partiql-eval/src/eval/expr/path.rs:3:32
  |
3 | pub use core::borrow::{Borrow, BorrowMut};
  |                                ^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: redundant pattern matching, consider using `is_some()`
     --> /home/runner/work/partiql-lang-rust/partiql-lang-rust/target/debug/build/partiql-parser-b7f563fc44f4149d/out/partiql.rs:47881:25
      |
47881 |         let recursive = matches!(rec, Some(_));
      |                         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `rec.is_some()`
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
      = note: `#[warn(clippy::redundant_pattern_matching)]` on by default

warning: unneeded `return` statement
   --> extension/partiql-extension-visualize/src/plan_to_dot.rs:209:9
    |
209 |         return String::from_utf8(output_bytes).expect("invalid utf8");
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
209 -         return String::from_utf8(output_bytes).expect("invalid utf8");
209 +         String::from_utf8(output_bytes).expect("invalid utf8")
    |

warning: returning the result of a `let` binding from a block
   --> extension/partiql-extension-visualize/src/plan_to_dot.rs:167:13
    |
166 |             let expr = expr.replace('>', "\\>");
    |             ------------------------------------ unnecessary `let` binding
167 |             expr
    |             ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
    = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
    |
166 ~             
167 ~             expr.replace('>', "\\>")
    |

warning: useless use of `format!`
   --> extension/partiql-extension-visualize/src/plan_to_dot.rs:139:25
    |
139 |             .set_label(&format!("{label}"));
    |                         ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `label.to_string()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

warning: useless use of `format!`
   --> extension/partiql-extension-visualize/src/plan_to_dot.rs:112:17
    |
112 |                 format!("{{project  * }}")
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"{project  * }".to_string()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

warning: redundant closure
  --> extension/partiql-extension-visualize/src/plan_to_dot.rs:97:30
   |
97 |                         .map(|e| expr_to_str(e))
   |                              ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `expr_to_str`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
   = note: `#[warn(clippy::redundant_closure)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> extension/partiql-extension-visualize/src/plan_to_dot.rs:77:67
   |
77 |                         .map(|e| format!("offset {}", expr_to_str(&e))),
   |                                                                   ^^ help: change this to: `e`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> extension/partiql-extension-visualize/src/plan_to_dot.rs:74:66
   |
74 |                         .map(|e| format!("limit {}", expr_to_str(&e))),
   |                                                                  ^^ help: change this to: `e`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this `impl` can be derived
  --> extension/partiql-extension-visualize/src/plan_to_dot.rs:13:1
   |
13 | / impl Default for PlanToDot {
14 | |     fn default() -> Self {
15 | |         PlanToDot {}
16 | |     }
17 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = help: remove the manual implementation...
help: ...and instead derive it
   |
11 + #[derive(Default)]
12 | pub struct PlanToDot {}
   |

warning: useless use of `format!`
   --> extension/partiql-extension-visualize/src/ast_to_dot.rs:458:45
    |
458 |         CaseSensitivity::CaseInsensitive => format!("{}", sym.value),
    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `sym.value.to_string()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
    = note: `#[warn(clippy::useless_format)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> extension/partiql-extension-visualize/src/ast_to_dot.rs:136:43
    |
136 |             Some(ast) => self.to_dot(out, &ast),
    |                                           ^^^^ help: change this to: `ast`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> extension/partiql-extension-visualize/src/ast_to_dot.rs:123:41
    |
123 |             res.extend(self.to_dot(out, &ast));
    |                                         ^^^^ help: change this to: `ast`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

warning: unneeded `return` statement
  --> extension/partiql-extension-visualize/src/ast_to_dot.rs:99:9
   |
99 |         return String::from_utf8(output_bytes).expect("invalid utf8");
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
   = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
   |
99 -         return String::from_utf8(output_bytes).expect("invalid utf8");
99 +         String::from_utf8(output_bytes).expect("invalid utf8")
   |

warning: this `impl` can be derived
  --> extension/partiql-extension-visualize/src/ast_to_dot.rs:62:1
   |
62 | / impl Default for AstToDot {
63 | |     fn default() -> Self {
64 | |         AstToDot {}
65 | |     }
66 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` on by default
   = help: remove the manual implementation...
help: ...and instead derive it
   |
60 + #[derive(Default)]
61 | pub struct AstToDot {}
   |

warning: the borrowed expression implements the required traits
  --> extension/partiql-extension-visualize/src/ast_to_dot.rs:52:29
   |
52 |             out.edge(&from, &target).attributes().set_label(lbl);
   |                             ^^^^^^^ help: change this to: `target`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
  --> extension/partiql-extension-visualize/src/ast_to_dot.rs:52:22
   |
52 |             out.edge(&from, &target).attributes().set_label(lbl);
   |                      ^^^^^ help: change this to: `from`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
   = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: single-character string constant used as pattern
  --> extension/partiql-extension-visualize/src/ast_to_dot.rs:32:48
   |
32 |         cluster.set("label", lbl, lbl.contains(" "));
   |                                                ^^^ help: try using a `char` instead: `' '`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
   = note: `#[warn(clippy::single_char_pattern)]` on by default