Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eval and explain functionalities to UI and APIs #6

Merged
merged 7 commits into from
Feb 17, 2023
Merged

Conversation

am357
Copy link
Contributor

@am357 am357 commented Feb 10, 2023

Description of changes:

  • Adds query evaluation and Explain to the playground using partiql-lang-rust 0.2.0 new features.
  • In addition it adds /explain and /eval REST APIs for Explain and evaluation functionalities.

UI Demo

Feb-15-2023 16-30-00

CLI Demo

Feb-16-2023 08-58-26

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Base: 1.56% // Head: 0.81% // Decreases project coverage by -0.75% ⚠️

Coverage data is based on head (6e232c2) compared to base (964e61e).
Patch coverage: 1.56% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##            main      #6      +/-   ##
========================================
- Coverage   1.56%   0.81%   -0.75%     
========================================
  Files          1       1              
  Lines         64     122      +58     
========================================
  Hits           1       1              
- Misses        63     121      +58     
Impacted Files Coverage Δ
src/lib.rs 0.81% <1.56%> (-0.75%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@am357 am357 force-pushed the feat-eval-explain branch 4 times, most recently from b3fbb2b to f97a1ab Compare February 16, 2023 17:14
@am357 am357 changed the title [DRAFT] Add eval and explain Add eval and explain functionalities to UI and APIs Feb 16, 2023
@am357 am357 marked this pull request as ready for review February 16, 2023 17:16
Copy link
Contributor

@yliuuuu yliuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull down and tested. Can confirm the submodule build is now successful.

Copy link
Member

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work getting the playground working with partiql-lang-rust v0.2.0! Left some minor comments related to wording and a suggestion

README.md Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/index.html Show resolved Hide resolved
am357 and others added 4 commits February 17, 2023 09:10
@am357 am357 merged commit 1068b6b into main Feb 17, 2023
@am357 am357 deleted the feat-eval-explain branch February 17, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants