-
Notifications
You must be signed in to change notification settings - Fork 12
PSR for LET, LETTING #21
base: psr-proposal
Are you sure you want to change the base?
Conversation
|
||
\subsection*{Lexical Scoping} | ||
|
||
Every \gn{var\_decl} included with \gl{WITH}, \gl{LET} or \gl{LETTING} is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: ... LETTING
is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can attach files to GitHub PRs. Can you attach the generated PDF? That would make it easy to review the content. The LaTeX source we can review using this diff.
%%%% | ||
%% Watermark | ||
%%%% | ||
\usepackage[firstpage]{draftwatermark} % to remove replace `firstpage` with `nostamp` | ||
\SetWatermarkScale{5.0} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing this? If you do not want the watermark to show, use the instructions in the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unnecessary because there is already the text --DRAFT--
in the heading of every page. Also, it was too big to fit on the page. You could only see part of R, the full A and part of F, previously. When I shrank it, it just looked bad and distracting (IMHO).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too attached to this I just found the text easier to read without the watermark. If the DRAFT watermark is convention or something let me know...
Reuploaded: main.pdf |
Revision LGTM. Think there was one typo not addressed yet. |
Contains a PSR for,
LET
, andLETTING
. I'm leaving most ofWITH
undefined at this point but I thinkLET
andLETTING
are pretty clear.The built PDF is intended to ultimately contain all of the current PSRs that haven't been adopted into the formal specification yet. At the moment there is only one. Also, this was intended to be easily copy & pasteable into the formal specification without a ton of effort, so it is written in LaTex, uses the same
preamble.tex
and moves some macros previously defined inspec/main.tex
tocommon/macros.tex
.To build:
Resulting pdf file resides in
spr/main.pdf
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.