Adjusts EXTRACT
tests to assert on result in statement
#84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to first part of #83.
Adjusts the
EXTRACT
builtin function tests to assert on the expected result in the PartiQL statement. This is to deal with the SQL specification's ambiguity related to the output type ofEXTRACT
. In SQL:2011 (pg 1337):where "exact numeric type" refers to "NUMERIC, DECIMAL, SMALLINT, INTEGER, and BIGINT" (pg 15).
Rather than defining the exact numeric type output by
EXTRACT
to be a decimal or integer, we add a PartiQL equality expression to assert the equivalent value.E.g. rewrite
as
This PR also adds some more tests that were omitted from the earlier test porting.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.