-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Diagonal operations handling in HamiltonianEvolution #282
Draft
chMoussa
wants to merge
26
commits into
main
Choose a base branch
from
cm/diag_obs_treatment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #211. This is an experimental feature to be checked with Qadence.
For generators that contains only diagonal operations, we avoid computing the whole tensor and use only the resulting diagonal. For this we introduce the option
diagonal
in certain operations. If set to True, the returned tensor would be of shape(2^n, batch_dim)
if the operation is really diagonal. One can convert to the diagonal form using theto_diagonal
method. Then apply methods have a new attribute that use different einsum indices for such cases.At the moment, we will only support such diagonal operations in
HamiltonianEvolution
, for the generator only. The returned tensors fromHamiltonianEvolution
would still be of shape(2^n, 2^n, batch_dim)
to be compatible with Qadence.