Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Change shadow algorithm for using only samples #608

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Conversation

chMoussa
Copy link
Collaborator

@chMoussa chMoussa commented Nov 11, 2024

Solves #607
Since we use shadows for computing expectation values only, the randomized version is just about using samples and averaging them for the case the sampled pauli-string correspond to the target pauli-string.

@chMoussa chMoussa added the bug Something isn't working label Nov 11, 2024
@chMoussa chMoussa self-assigned this Nov 11, 2024
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ! Minor comment and LGTM !

qadence/measurements/shadow.py Outdated Show resolved Hide resolved
@chMoussa chMoussa merged commit d61f83d into main Nov 12, 2024
6 checks passed
@chMoussa chMoussa deleted the cm/fix_shadows branch November 12, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants