Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DE-233) feat(api-reco): include by default list of items for retrieval + add factory #239

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cdelabre
Copy link
Contributor

Select PR template in preview mode:

@cdelabre cdelabre changed the title DE-233/refactor-items-retrieval (DE-233) feat(api-reco): include by default list of items for retrieval + add factory Oct 11, 2024
Copy link

Risk Level 2 - /home/runner/work/api-data/api-data/apps/recommendation/api/src/huggy/core/model_selection/model_configuration/configuration.py

  1. The addition of Optional from typing is a good practice for type hinting, improving code readability and maintainability.
  2. Ensure that the logic for determining the model status based on user and offer interactions is thoroughly tested to prevent unexpected behavior.

Risk Level 2 - /home/runner/work/api-data/api-data/apps/recommendation/api/src/huggy/core/scorer/offer.py

  1. The addition of input_offers handling in various methods is consistent with the changes across the codebase. Ensure that input_offers is validated to prevent potential errors.
  2. The get_offer_coordinates method is a useful addition for calculating average coordinates, but ensure that it handles cases where no geolocated offers are present.

Risk Level 2 - /home/runner/work/api-data/api-data/apps/recommendation/api/src/huggy/crud/recommendable_offer.py

  1. The addition of is_geolocated method is a useful utility for determining geolocation status. Ensure that it handles cases where both user and input offers are not geolocated.
  2. The get_st_distance method now handles input offers, which is a good addition, but ensure that it handles cases where no geolocated offers are present.

🔍✅🛠️


Powered by Code Review GPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants