(BSR) docs(features): upgrade user's workflow #6962

pierrecanthelou · 2024-10-04T08:56:08Z

Update existing graphs and add one to explain subscription based on age and school type.

To test you can clic the "View file" menu

sonarcloud · 2024-10-04T09:02:46Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-10-04T09:04:45Z

Performance Comparison Report

Current: HEAD (d2658a4)
Baseline: master (305a4fc)

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries

Name	Render Duration	Render Count
Performance test for Bookings page	61.3 ms → 62.0 ms (+0.7 ms, +1.1%)	9 → 9
Search Landing Page - Performance test for Search Landing page	14.2 ms → 14.6 ms (+0.4 ms, +2.8%)	5 → 5
Performance test for EndedBookings page	30.8 ms → 31.2 ms (+0.4 ms, +1.3%)	6 → 6
Performance test for Venue page	2.8 ms → 2.9 ms (+0.1 ms, +3.6%)	2 → 2
Search Results - Performance test for Search Results page	14.3 ms → 14.4 ms (+0.1 ms, +0.7%)	5 → 5
Performance test for Profile page	6.5 ms → 6.2 ms (-0.3 ms, -4.6%)	5 → 5
Performance test for Favorites page	65.6 ms → 64.3 ms (-1.3 ms, -2.0%)	6 → 6
Performance test for Offer page	174.2 ms → 170.2 ms (-4.0 ms, -2.3%)	4 → 4

Show details

Name	Render Duration	Render Count
Performance test for Bookings page	Baseline Mean: 61.3 ms Stdev: 2.8 ms (4.5%) Runs: 66 65 63 62 62 60 59 59 59 58 Current Mean: 62.0 ms Stdev: 2.1 ms (3.3%) Runs: 67 64 62 62 61 61 61 61 61 60	Baseline Mean: 9 Stdev: 0 (0.0%) Runs: 9 9 9 9 9 9 9 9 9 9 Current Mean: 9 Stdev: 0 (0.0%) Runs: 9 9 9 9 9 9 9 9 9 9
Search Landing Page - Performance test for Search Landing page	Baseline Mean: 14.2 ms Stdev: 1.5 ms (10.9%) Runs: 17 16 15 15 14 14 13 13 13 12 Current Mean: 14.6 ms Stdev: 1.0 ms (6.6%) Runs: 16 16 15 15 15 14 14 14 14 13	Baseline Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5 Current Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page	Baseline Mean: 30.8 ms Stdev: 1.4 ms (4.5%) Runs: 33 32 32 32 31 30 30 30 29 29 Current Mean: 31.2 ms Stdev: 1.9 ms (6.0%) Runs: 33 33 33 33 32 31 30 30 29 28	Baseline Mean: 6 Stdev: 0 (0.0%) Runs: 6 6 6 6 6 6 6 6 6 6 Current Mean: 6 Stdev: 0 (0.0%) Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Venue page	Baseline Mean: 2.8 ms Stdev: 0.6 ms (22.6%) Runs: 4 3 3 3 3 3 3 2 2 2 Current Mean: 2.9 ms Stdev: 0.7 ms (25.4%) Runs: 4 4 3 3 3 3 3 2 2 2	Baseline Mean: 2 Stdev: 0 (0.0%) Runs: 2 2 2 2 2 2 2 2 2 2 Current Mean: 2 Stdev: 0 (0.0%) Runs: 2 2 2 2 2 2 2 2 2 2
Search Results - Performance test for Search Results page	Baseline Mean: 14.3 ms Stdev: 1.3 ms (8.8%) Runs: 16 16 15 15 14 14 14 14 13 12 Current Mean: 14.4 ms Stdev: 1.1 ms (7.5%) Runs: 16 15 15 15 15 14 14 14 14 12	Baseline Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5 Current Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Profile page	Baseline Mean: 6.5 ms Stdev: 0.7 ms (10.9%) Runs: 8 7 7 7 6 6 6 6 6 6 Current Mean: 6.2 ms Stdev: 1.1 ms (18.3%) Runs: 8 7 7 7 6 6 6 6 5 4	Baseline Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5 Current Mean: 5 Stdev: 0 (0.0%) Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Favorites page	Baseline Mean: 65.6 ms Stdev: 2.2 ms (3.4%) Runs: 69 69 67 66 66 65 64 64 63 63 Current Mean: 64.3 ms Stdev: 3.0 ms (4.6%) Runs: 70 68 66 65 64 63 63 62 61 61	Baseline Mean: 6 Stdev: 0 (0.0%) Runs: 6 6 6 6 6 6 6 6 6 6 Current Mean: 6 Stdev: 0 (0.0%) Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Offer page	Baseline Mean: 174.2 ms Stdev: 7.8 ms (4.5%) Runs: 187 186 179 175 172 172 171 171 166 163 Current Mean: 170.2 ms Stdev: 3.7 ms (2.2%) Runs: 177 175 172 172 169 169 168 168 167 165	Baseline Mean: 4 Stdev: 0 (0.0%) Runs: 4 4 4 4 4 4 4 4 4 4 Current Mean: 4 Stdev: 0 (0.0%) Runs: 4 4 4 4 4 4 4 4 4 4

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 6e8f927

sonarcloud · 2024-10-04T09:08:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

bruno-ebstein-pass-culture

j'aimerais une review de @lixxday @cepehang @thconte

bruno-ebstein-pass-culture · 2024-10-08T08:40:55Z

doc/inscription.mmd

+title: Diagramme des méthodes d'inscriptions
+---
+stateDiagram-v2
+  direction LR


ça serait probablement plus facile à lire verticalement

Suggested change

direction LR

direction TB

J'ai testé et je ne trouve pas, je préfère garder la version horizontale

bruno-ebstein-pass-culture · 2024-10-08T08:42:13Z

doc/inscription.mmd

+  %% style s5 fill:#BBDEFB
+  %% style s8 fill:#00C853
+  %% style s12 fill:#FFCDD2
+  %% style s13 fill:#FFD600


ça ne sert à rien de garder du code mort

Je veux voir si ça colorie sur Github :)

là, c'est commenté, donc ça ne fera rien

bruno-ebstein-pass-culture · 2024-10-08T08:42:19Z

doc/inscription.mmd

+  s7:Jeunes scolarisé MEN
+  s8:Bénéficiaire
+  s12:Ubble
+  s13:DMS


il manque un lien de DMS à bénéficiaire

bruno-ebstein-pass-culture · 2024-10-08T08:45:16Z

doc/user_status.mmd

+            has_subscription_pending --> beneficiary_15_17 : < 18
+            has_subscription_pending --> beneficiary_18 : > 18


comment as-tu testé ?

ce lien ne se render pas bien sur GitHub https://github.com/pass-culture/pass-culture-app-native/blob/6e8f927a250753ab346f4f49be3cfca93173bfa0/doc/user_status.mmd

J'avais regardé le rendu pourtant et n'avais pas vu de soucis

Ah oui ! Je regarde ça !

bruno-ebstein-pass-culture · 2024-10-08T08:48:06Z

doc/user_status.mmd

@@ -34,10 +35,18 @@ stateDiagram-v2
                [*] --> without_booking_18
                without_booking_18 --> with_some_bookings_18
            }
+
+            beneficiary_15_17 --> ex_beneficiary_15_17 : birthday 18 🎂
+            beneficiary_18 --> ex_beneficiary : 24 month later ⌛


on est précis pour les 15 17

on pourrait etre aussi précis pour les 18

Suggested change

beneficiary_18 --> ex_beneficiary : 24 month later ⌛

beneficiary_18 --> ex_beneficiary_18 : 24 month later ⌛

pas faux et est-ce que ce status existe car j'ai vu ça comme status pour les 15-17 ex-underage-beneficiary

je ne sais pas

bruno-ebstein-pass-culture · 2024-10-08T08:49:35Z

doc/user_status.mmd

+
+        state ex_beneficiary {
+            ex_beneficiary_18: to_old
+            ex_beneficiary_15_17 : like_eligible


il me semble que ce status n'éxiste pas coté backend

quand un-e bénéficiaire passe de 17 à 18 ans, iel redevient éligible

Le passage de 17 à 18 fait passer le jeu en ex_beneficiary_15_17 et il est eligible mais doit faire la procedure d'inscription 18 ans.
Comment verrais-tu la représentation ?

il est eligible mais doit faire la procedure d'inscription 18 ans.

pour moi "il est eligible" == "doit faire la procedure d'inscription 18 ans"

Le passage de 17 à 18 fait passer le jeu en ex_beneficiary_15_17

je trouve pas de status correspondant coté backend

bruno-ebstein-pass-culture · 2024-10-08T08:51:11Z

doc/user_status.mmd

+        }
+
+        state ex_beneficiary {
+            ex_beneficiary_18: to_old


je ne crois pas qu'il y ai de notion de "trop vieux" après les 24 mois

il me semble que c'est juste un-e ex-bénéficiaire

bruno-ebstein-pass-culture · 2024-10-08T08:55:31Z

doc/inscription.mmd

+  s7:Jeunes scolarisé MEN
+  s8:Bénéficiaire
+  s12:Ubble
+  s13:DMS


il me semble qu'on peut utiliser DMS meme si on a 15 17 et scolarisé ou si on a 18 ans et est français

On peut aussi utiliser Ubble en étant scolarisé.
15-17 : DMS, Educonnect, Ubble.
18+ : DMS, Ubble.

Je précise MEN = Ministère de l'éduction nationale
Donc ce que je voulais représenter et qui est peut-être faux :

15-17 scolarisé MEN -> Educonnect

15-17 scolarisé non-MEN/non-scolarisé -> Ubble ou DMS mais pas Educonnect

18+ français à priori est routé sur Ubble et DMS si soucis mais pas DMS du premier coup

pierrecanthelou added 2 commits October 4, 2024 10:47

Refine workflow for beneficiary user

bb28ec1

add subscription workflow

6e8f927

pierrecanthelou requested review from bruno-ebstein-pass-culture, tanguyprache and Lucasbeneston and removed request for tanguyprache October 4, 2024 08:56

Lucasbeneston approved these changes Oct 4, 2024

View reviewed changes

bruno-ebstein-pass-culture reviewed Oct 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(BSR) docs(features): upgrade user's workflow #6962

(BSR) docs(features): upgrade user's workflow #6962

pierrecanthelou commented Oct 4, 2024 •

edited

Loading

sonarcloud bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

sonarcloud bot commented Oct 4, 2024

bruno-ebstein-pass-culture left a comment

bruno-ebstein-pass-culture Oct 8, 2024

pierrecanthelou Oct 9, 2024

bruno-ebstein-pass-culture Oct 8, 2024

pierrecanthelou Oct 9, 2024

bruno-ebstein-pass-culture Oct 9, 2024

bruno-ebstein-pass-culture Oct 8, 2024

pierrecanthelou Oct 9, 2024

bruno-ebstein-pass-culture Oct 8, 2024

pierrecanthelou Oct 9, 2024

bruno-ebstein-pass-culture Oct 9, 2024

pierrecanthelou Oct 9, 2024

bruno-ebstein-pass-culture Oct 8, 2024

pierrecanthelou Oct 9, 2024

bruno-ebstein-pass-culture Oct 9, 2024

bruno-ebstein-pass-culture Oct 8, 2024

pierrecanthelou Oct 9, 2024

bruno-ebstein-pass-culture Oct 9, 2024

bruno-ebstein-pass-culture Oct 8, 2024

bruno-ebstein-pass-culture Oct 8, 2024

tconte-pass Oct 8, 2024

pierrecanthelou Oct 9, 2024

		has_subscription_pending --> beneficiary_15_17 : < 18
		has_subscription_pending --> beneficiary_18 : > 18

	beneficiary_18 --> ex_beneficiary : 24 month later ⌛
	beneficiary_18 --> ex_beneficiary_18 : 24 month later ⌛

(BSR) docs(features): upgrade user's workflow #6962

Are you sure you want to change the base?

(BSR) docs(features): upgrade user's workflow #6962

Conversation

pierrecanthelou commented Oct 4, 2024 • edited Loading

sonarcloud bot commented Oct 4, 2024

Quality Gate passed

github-actions bot commented Oct 4, 2024

Performance Comparison Report

Significant Changes To Render Duration

Meaningless Changes To Render Duration

Changes To Render Count

Added Scenarios

Removed Scenarios

sonarcloud bot commented Oct 4, 2024

Quality Gate passed

bruno-ebstein-pass-culture left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pierrecanthelou commented Oct 4, 2024 •

edited

Loading