Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32564) feat(culturalSurvey): fix cultural survey questions to dis… #7068

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Lucasbeneston
Copy link
Contributor

@Lucasbeneston Lucasbeneston commented Oct 21, 2024

…play

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32564

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS
Android
Phone - Chrome
Desktop - Chrome

Copy link

github-actions bot commented Oct 21, 2024

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for Bookings page 96.5 ms → 98.7 ms (+2.2 ms, +2.3%) 11 → 11
Performance test for EndedBookings page 30.6 ms → 31.4 ms (+0.8 ms, +2.6%) 6 → 6
Performance test for Venue page 3.0 ms → 2.8 ms (-0.2 ms, -6.7%) 2 → 2
Search Results - Performance test for Search Results page 14.7 ms → 14.2 ms (-0.5 ms, -3.4%) 5 → 5
Performance test for Profile page 6.9 ms → 6.3 ms (-0.6 ms, -8.7%) 5 → 5
Performance test for Favorites page 65.5 ms → 64.8 ms (-0.7 ms, -1.1%) 6 → 6
Search Landing Page - Performance test for Search Landing page 15.1 ms → 13.4 ms (-1.7 ms, -11.3%) 5 → 5
Performance test for Offer page 73.5 ms → 71.8 ms (-1.7 ms, -2.3%) 2 → 2
Show details
Name Render Duration Render Count
Performance test for Bookings page Baseline
Mean: 96.5 ms
Stdev: 2.9 ms (3.0%)
Runs: 100 99 98 98 98 97 96 95 94 90

Current
Mean: 98.7 ms
Stdev: 3.2 ms (3.2%)
Runs: 103 102 101 101 100 99 96 96 95 94
Baseline
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11

Current
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11
Performance test for EndedBookings page Baseline
Mean: 30.6 ms
Stdev: 1.1 ms (3.5%)
Runs: 33 31 31 31 31 30 30 30 30 29

Current
Mean: 31.4 ms
Stdev: 2.3 ms (7.4%)
Runs: 35 35 33 32 31 31 30 29 29 29
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Venue page Baseline
Mean: 3.0 ms
Stdev: 0.8 ms (27.2%)
Runs: 4 4 4 3 3 3 3 2 2 2

Current
Mean: 2.8 ms
Stdev: 0.8 ms (28.2%)
Runs: 4 4 3 3 3 3 2 2 2 2
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Search Results - Performance test for Search Results page Baseline
Mean: 14.7 ms
Stdev: 1.4 ms (9.6%)
Runs: 17 16 16 15 15 15 14 13 13 13

Current
Mean: 14.2 ms
Stdev: 1.1 ms (8.0%)
Runs: 16 15 15 15 14 14 14 14 13 12
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Profile page Baseline
Mean: 6.9 ms
Stdev: 0.9 ms (12.7%)
Runs: 8 8 8 7 7 7 6 6 6 6

Current
Mean: 6.3 ms
Stdev: 0.7 ms (10.7%)
Runs: 7 7 7 7 6 6 6 6 6 5
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Favorites page Baseline
Mean: 65.5 ms
Stdev: 2.5 ms (3.8%)
Runs: 68 68 68 67 66 66 65 64 62 61

Current
Mean: 64.8 ms
Stdev: 2.1 ms (3.2%)
Runs: 68 67 67 66 65 64 63 63 63 62
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 15.1 ms
Stdev: 1.9 ms (12.3%)
Runs: 19 17 16 15 15 15 14 14 13 13

Current
Mean: 13.4 ms
Stdev: 1.6 ms (11.8%)
Runs: 16 15 14 14 14 14 12 12 12 11
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Offer page Baseline
Mean: 73.5 ms
Stdev: 3.5 ms (4.8%)
Runs: 80 77 76 75 74 72 71 71 70 69

Current
Mean: 71.8 ms
Stdev: 2.8 ms (3.9%)
Runs: 78 74 72 72 72 72 71 70 69 68
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 25f5f5b

Copy link

sonarcloud bot commented Oct 21, 2024

Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
80.0% Coverage on New Code (required ≥ 85%)

See analysis details on SonarCloud

@Lucasbeneston Lucasbeneston merged commit c989552 into master Oct 22, 2024
51 of 52 checks passed
@Lucasbeneston Lucasbeneston deleted the PC-32564 branch October 22, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants