(PC-32595)[PRO] refactor: test e2e

pass-culture · Oct 22, 2024 · fc36021 · fc36021
1 parent fc6c6de
commit fc36021
Show file tree

Hide file tree

Showing 8 changed files with 137 additions and 191 deletions.
diff --git a/pro/cypress/e2e/adage.cy.ts b/pro/cypress/e2e/adage.cy.ts
@@ -182,6 +182,14 @@ describe('ADAGE discovery', () => {
           },
         })
     ).as('searchOfferTemplate')
+    cy.intercept({
+      method: 'DELETE',
+      url: '/adage-iframe/collective/template/**/favorites',
+    }).as('delete_fav')
+    cy.intercept({
+      method: 'POST',
+      url: '/adage-iframe/logs/fav-offer/',
+    }).as('fav-offer')
   })
 
   it('It should put an offer in favorite', () => {
@@ -194,10 +202,6 @@ describe('ADAGE discovery', () => {
 
     cy.stepLog({ message: 'I add first offer to favorites' })
     cy.findByText(offerName).parent().click()
-    cy.intercept({
-      method: 'POST',
-      url: '/adage-iframe/logs/fav-offer/',
-    }).as('fav-offer')
     cy.findByTestId('favorite-inactive').click()
     cy.wait('@fav-offer', { responseTimeout: 30 * 1000 })
       .its('response.statusCode')
@@ -212,10 +216,6 @@ describe('ADAGE discovery', () => {
     cy.contains(offerName).should('be.visible')
 
     cy.stepLog({ message: 'we can remove it from favorites' })
-    cy.intercept({
-      method: 'DELETE',
-      url: '/adage-iframe/collective/template/**/favorites',
-    }).as('delete_fav')
     cy.findByTestId('favorite-active').click()
     cy.wait('@delete_fav').its('response.statusCode').should('eq', 204)
     cy.findByTestId('global-notification-success').should(

diff --git a/pro/cypress/e2e/collectiveBooking.cy.ts b/pro/cypress/e2e/collectiveBooking.cy.ts
@@ -1,46 +1,5 @@
 import { addDays, format } from 'date-fns'
 
-function expectOffersAreFound(expectedResults: Array<Array<string>>) {
-  for (let rowLine = 0; rowLine < expectedResults.length - 1; rowLine++) {
-    const offerLineArray = expectedResults[rowLine + 1]
-
-    cy.findAllByTestId('offer-item-row')
-      .eq(rowLine)
-      .within(() => {
-        cy.get('td').then(($elt) => {
-          for (let column = 0; column < 5; column++) {
-            cy.wrap($elt)
-              .eq(column)
-              .then((cellValue) => {
-                if (cellValue.text().length && offerLineArray[column].length) {
-                  return cy
-                    .wrap(cellValue)
-                    .should('contain.text', offerLineArray[column])
-                } else {
-                  return true
-                }
-              })
-          }
-        })
-      })
-  }
-}
-
-function IGoToCollectivePage(login: string) {
-  const password = 'user@AZERTY123'
-
-  cy.stepLog({ message: 'I am logged in' })
-  cy.login({
-    email: login,
-    password: password,
-    redirectUrl: '/',
-  })
-  cy.findAllByTestId('spinner').should('not.exist')
-
-  cy.stepLog({ message: 'I open the "reservations/collectives" page' })
-  cy.visit('/reservations/collectives')
-}
-
 describe('Search for collective bookings', () => {
   let login: string
 
@@ -178,3 +137,44 @@ describe('Search for collective bookings', () => {
     expectOffersAreFound(expectedResults)
   })
 })
+
+function expectOffersAreFound(expectedResults: Array<Array<string>>) {
+  for (let rowLine = 0; rowLine < expectedResults.length - 1; rowLine++) {
+    const offerLineArray = expectedResults[rowLine + 1]
+
+    cy.findAllByTestId('offer-item-row')
+      .eq(rowLine)
+      .within(() => {
+        cy.get('td').then(($elt) => {
+          for (let column = 0; column < 5; column++) {
+            cy.wrap($elt)
+              .eq(column)
+              .then((cellValue) => {
+                if (cellValue.text().length && offerLineArray[column].length) {
+                  return cy
+                    .wrap(cellValue)
+                    .should('contain.text', offerLineArray[column])
+                } else {
+                  return true
+                }
+              })
+          }
+        })
+      })
+  }
+}
+
+function IGoToCollectivePage(login: string) {
+  const password = 'user@AZERTY123'
+
+  cy.stepLog({ message: 'I am logged in' })
+  cy.login({
+    email: login,
+    password: password,
+    redirectUrl: '/',
+  })
+  cy.findAllByTestId('spinner').should('not.exist')
+
+  cy.stepLog({ message: 'I open the "reservations/collectives" page' })
+  cy.visit('/reservations/collectives')
+}
diff --git a/pro/cypress/e2e/cookieBanner.cy.ts b/pro/cypress/e2e/cookieBanner.cy.ts
@@ -1,10 +1,3 @@
-function homePageLoaded(): void {
-  cy.findByText('Bienvenue dans l’espace acteurs culturels')
-  cy.findByText('Vos adresses')
-  cy.findByText('Ajouter un lieu')
-  cy.findAllByTestId('spinner').should('not.exist')
-}
-
 describe('Cookie management with no login', () => {
   beforeEach(() => {
     cy.visit('/connexion')
@@ -242,3 +235,10 @@ describe('Cookie management with login', () => {
     cy.get('#orejime-app-item-beamer').should('not.be.checked')
   })
 })
+
+function homePageLoaded(): void {
+  cy.findByText('Bienvenue dans l’espace acteurs culturels')
+  cy.findByText('Vos adresses')
+  cy.findByText('Ajouter un lieu')
+  cy.findAllByTestId('spinner').should('not.exist')
+}
diff --git a/pro/cypress/e2e/desk.cy.ts b/pro/cypress/e2e/desk.cy.ts
@@ -2,7 +2,6 @@ import { addDays, format } from 'date-fns'
 
 describe('Desk (Guichet) feature', () => {
   let login: string
-  const password = 'user@AZERTY123'
 
   beforeEach(() => {
     cy.visit('/connexion')
@@ -15,16 +14,7 @@ describe('Desk (Guichet) feature', () => {
   })
 
   it('I should see help information on desk page', () => {
-    cy.stepLog({ message: 'I am logged in with account' })
-    cy.login({
-      email: login,
-      password: password,
-      redirectUrl: '/',
-    })
-
-    cy.stepLog({ message: 'I go to the "Guichet" page' })
-    cy.findAllByText('Guichet').first().click()
-    cy.url().should('contain', '/guichet')
+    goToDeskPage(login)
 
     cy.stepLog({ message: 'The identity check message is displayed' })
     cy.findByText(
@@ -49,16 +39,7 @@ describe('Desk (Guichet) feature', () => {
   })
 
   it('Should validate a countermark', () => {
-    cy.stepLog({ message: 'I am logged in with account' })
-    cy.login({
-      email: login,
-      password: password,
-      redirectUrl: '/',
-    })
-
-    cy.stepLog({ message: 'I go to the "Guichet" page' })
-    cy.findAllByText('Guichet').first().click()
-    cy.url().should('contain', '/guichet')
+    goToDeskPage(login)
 
     cy.stepLog({ message: 'I add this countermark "2XTM3W"' })
     cy.findByLabelText('Contremarque').type('2XTM3W')
@@ -72,16 +53,7 @@ describe('Desk (Guichet) feature', () => {
   })
 
   it('It should decline a non-valid countermark', () => {
-    cy.stepLog({ message: 'I am logged in with account' })
-    cy.login({
-      email: login,
-      password: password,
-      redirectUrl: '/',
-    })
-
-    cy.stepLog({ message: 'I go to the "Guichet" page' })
-    cy.findAllByText('Guichet').first().click()
-    cy.url().should('contain', '/guichet')
+    goToDeskPage(login)
 
     cy.stepLog({ message: 'I add this countermark "XXXXXX"' })
     cy.findByLabelText('Contremarque').type('XXXXXX')
@@ -95,16 +67,7 @@ describe('Desk (Guichet) feature', () => {
   })
 
   it('It should decline an event countermark more than 48h before', () => {
-    cy.stepLog({ message: 'I am logged in with account' })
-    cy.login({
-      email: login,
-      password: password,
-      redirectUrl: '/',
-    })
-
-    cy.stepLog({ message: 'I go to the "Guichet" page' })
-    cy.findAllByText('Guichet').first().click()
-    cy.url().should('contain', '/guichet')
+    goToDeskPage(login)
 
     cy.stepLog({ message: 'I add this countermark "TOSOON"' })
     cy.findByLabelText('Contremarque').type('TOSOON')
@@ -121,16 +84,7 @@ describe('Desk (Guichet) feature', () => {
   })
 
   it('Should invalidate a already used countermark', () => {
-    cy.stepLog({ message: 'I am logged in with account' })
-    cy.login({
-      email: login,
-      password: password,
-      redirectUrl: '/',
-    })
-
-    cy.stepLog({ message: 'I go to the "Guichet" page' })
-    cy.findAllByText('Guichet').first().click()
-    cy.url().should('contain', '/guichet')
+    goToDeskPage(login)
 
     cy.stepLog({ message: 'I add this countermark "XUSEDX"' })
     cy.findByLabelText('Contremarque').type('XUSEDX')
@@ -145,16 +99,7 @@ describe('Desk (Guichet) feature', () => {
   })
 
   it('Should not be able to validate an other pro countermark', () => {
-    cy.stepLog({ message: 'I am logged in with account' })
-    cy.login({
-      email: login,
-      password: password,
-      redirectUrl: '/',
-    })
-
-    cy.stepLog({ message: 'I go to the "Guichet" page' })
-    cy.findAllByText('Guichet').first().click()
-    cy.url().should('contain', '/guichet')
+    goToDeskPage(login)
 
     cy.stepLog({ message: 'I add this countermark "OTHERX"' })
     cy.findByLabelText('Contremarque').type('OTHERX')
@@ -167,16 +112,7 @@ describe('Desk (Guichet) feature', () => {
   })
 
   it('Should not be able to validate a cancelled countermark', () => {
-    cy.stepLog({ message: 'I am logged in with account' })
-    cy.login({
-      email: login,
-      password: password,
-      redirectUrl: '/',
-    })
-
-    cy.stepLog({ message: 'I go to the "Guichet" page' })
-    cy.findAllByText('Guichet').first().click()
-    cy.url().should('contain', '/guichet')
+    goToDeskPage(login)
 
     cy.stepLog({ message: 'I add this countermark "CANCEL"' })
     cy.findByLabelText('Contremarque').type('CANCEL')
@@ -187,16 +123,7 @@ describe('Desk (Guichet) feature', () => {
   })
 
   it('Should not be able to validate a reimbursed countermark', () => {
-    cy.stepLog({ message: 'I am logged in with account' })
-    cy.login({
-      email: login,
-      password: password,
-      redirectUrl: '/',
-    })
-
-    cy.stepLog({ message: 'I go to the "Guichet" page' })
-    cy.findAllByText('Guichet').first().click()
-    cy.url().should('contain', '/guichet')
+    goToDeskPage(login)
 
     cy.stepLog({ message: 'I add this countermark "REIMBU"' })
     cy.findByLabelText('Contremarque').type('REIMBU')
@@ -206,3 +133,18 @@ describe('Desk (Guichet) feature', () => {
     cy.findByText('Cette réservation a été remboursée')
   })
 })
+
+function goToDeskPage(login: string) {
+  const password = 'user@AZERTY123'
+
+  cy.stepLog({ message: 'I am logged in with account' })
+  cy.login({
+    email: login,
+    password: password,
+    redirectUrl: '/',
+  })
+
+  cy.stepLog({ message: 'I go to the "Guichet" page' })
+  cy.findAllByText('Guichet').first().click()
+  cy.url().should('contain', '/guichet')
+}
diff --git a/pro/cypress/e2e/financialManagement.cy.ts b/pro/cypress/e2e/financialManagement.cy.ts
@@ -11,7 +11,9 @@ describe('Financial Management - messages, links to external help page, reimburs
       login = response.body.user.email
     })
     cy.intercept({ method: 'GET', url: '/offerers/*' }).as('getOfferers')
-    cy.intercept({ method: 'GET', url: '/offerers/*/bank-accounts' }).as('getOfferersBankAccounts')
+    cy.intercept({ method: 'GET', url: '/offerers/*/bank-accounts' }).as(
+      'getOfferersBankAccounts'
+    )
   })
 
   it('Check messages, reimbursement details and offerer selection change', () => {
@@ -181,7 +183,9 @@ describe('Financial Management - messages, links to external help page, reimburs
       cy.findByLabelText(venue).uncheck()
       cy.findByText('Enregistrer').click()
       cy.findByText('Confirmer').click()
-      cy.wait('@getOfferersBankAccounts').its('response.statusCode').should('equal', 200)
+      cy.wait('@getOfferersBankAccounts')
+        .its('response.statusCode')
+        .should('equal', 200)
     })
 
     cy.stepLog({ message: 'no venue should be linked to my account' })

diff --git a/pro/cypress/e2e/navigation.cy.ts b/pro/cypress/e2e/navigation.cy.ts
@@ -2,7 +2,7 @@ describe('Navigation', () => {
   let login = ''
   const password = 'user@AZERTY123'
 
-  before(() => {
+  beforeEach(() => {
     cy.visit('/connexion')
     cy.request({
       method: 'GET',