Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-32535)[BO] feat: dedicated permission for 'connect-as' feature #14659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

(PC-32535)[BO] feat: dedicated permission for 'connect-as' feature #14659

wants to merge 2 commits into from
+65 −14

Conversation

prouzet
Copy link
Contributor

@prouzet prouzet commented Oct 18, 2024

But de la pull request

Ticket Jira : https://passculture.atlassian.net/browse/PC-32535

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques

Meewan
Meewan approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Meewan Meewan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne connaissais pas les insert avec une subquery mais en y repensant c'est logique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meewan Meewan Meewan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prouzet @Meewan @prouzet-pass