Update Void Element List (Update Rails Edge) #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest Rails Edge no longer tracks void elements as a constant. Instead of depending on this, we just hardcode the known void list from the latest live html standard. (Dated 2024-02) This also removes Ruby 3.0 from the supported list for two reasons; It is EoL in March, Rails Edge no longer supports it.
zacheryph
commented
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple things due to reasons.
Removes Ruby 3.0 Support. Ruby 3.0 is EoL at the end of March, and also, Rails Edge does not support 3.0 and will simply not run at all (so all the tests fail.)
Hard codes
HTML_VOID_ELEMENTS. Rails removed this constant, and replaced them with a new mechanism (which is how they track all elements.) I decided to hard code these ourselves, with a link to the living HTML standard where these are listed (This document states it was last updated Feb 24th 2024 so... up to date)