PatchWork AutoFix #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 25, 2024 09:25
…kallj41/sqli/dao/user.py
…kallj41/sqli/dao/student.py
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -38,4 +38,4 @@ | |||
| return User.from_raw(await cur.fetchone()) | |||
|
|
|||
| def check_password(self, password: str): | |||
| return self.pwd_hash == md5(password.encode('utf-8')).hexdigest() | |||
| return self.pwd_hash == scrypt(password.encode('utf-8'), salt=b'salt', n=16384, r=8, p=1) | |||
Check failure
Code scanning / SonarCloud
Password hashing functions should use an unpredictable salt High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request from patched fixes 2 issues.
Fix SQL Injection vulnerability by using parameterized queries
Used parameterized queries to prevent SQL Injection vulnerability in the create method of the Student class.Fix security vulnerability by replacing usage of MD5 with a secure hashing function
Replaced MD5 hashing with scrypt hashing for secure password storage.