Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for early versions of CIP specification #1

Merged
merged 5 commits into from
Oct 7, 2020

Conversation

ryan-path
Copy link

Add support for early versions of CIP specification

http://read.pudn.com/downloads589/doc/2410232/CIP%20Vol1_3.3.pdf
Page 95
Section 3-5.5.1.1
connection parameters are only 16 bits

@ryan-path
Copy link
Author

ryan-path commented Sep 16, 2020

This might not be complete but I at least wanted to get what I have working saved somewhere other then on my machine.

…-boost-noetic

Fix/get io service boost noetic
http://read.pudn.com/downloads589/doc/2410232/CIP%20Vol1_3.3.pdf
Page 95
Section 3-5.5.1.1
connection parameters are only 16 bits

Also adds an option to not fully close the conncetion. This allows reconnection for slightly offspec devices.
@ryan-path
Copy link
Author

I have opened a PR so it might make more sense to wait for that unless we end up with multiple changes needed.

@bkent324 bkent324 merged commit f0a3e27 into kinetic-devel Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants