-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "proportionality to" to "ratio" #556
Conversation
of * PATO:0001470 ratio and child terms * PATO:0040043 increased ratio * PATO:0040042 decreased ratio Also, improve the logical definitions of 'increased ratio' and 'decreased' by using EQs. Resolve #555
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see proportionality to used in the eqs for 4 MP terms (eg.abnormal lymph node cell ratio) these have eqs in the form We aren't currently using increased or decreased child terms The one thing that gives me pause is this part of the comment on the old term "Not all ratios measure proportionality, eg m/s measures velocity which is not a proportion in the sense defined above, it is a quality in its own right." But looking at the definition in both the old and new versions, I think the inclusion of 'the magnitude of another entity' excludes velocity since this involves a single entity. I think the changes to the definition do not significantly alter the meaning of the term, so I am okay with this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is acceptable (longer comment in conversation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except one typo.
Co-authored-by: Jim Balhoff <[email protected]>
@rays22 Looks good. I just have a comment on whether the synonyms in the pattern should also reflect 'percentage' terms. For example terms like EFO:0007993 lymphocyte percentage of leukocytes describe a ratio relationship. |
@ar-ibrahim , In the specific case of EFO:0007993, yes, using the PATIO 'ratio' quality would be appropriate based on this part of the textual definition: ... presented as a ratio, fraction, quotient or percentage. |
of
Also, improve the textual definitions and
improve the logical definitions of 'increased ratio' and 'decreased' by using EQs.
Resolve #555