Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "proportionality to" to "ratio" #556

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Rename "proportionality to" to "ratio" #556

merged 2 commits into from
Mar 14, 2024

Conversation

rays22
Copy link
Collaborator

@rays22 rays22 commented Feb 28, 2024

of

  • PATO:0001470 ratio and child terms
  • PATO:0040043 increased ratio
  • PATO:0040042 decreased ratio

Also, improve the textual definitions and
improve the logical definitions of 'increased ratio' and 'decreased' by using EQs.

Resolve #555

of
* PATO:0001470 ratio
and child terms
* PATO:0040043 increased ratio
* PATO:0040042 decreased ratio

Also, improve the logical definitions of 'increased ratio' and 'decreased' by using EQs.

Resolve #555
@rays22 rays22 self-assigned this Feb 28, 2024
@matentzn matentzn changed the title Make ratio the primary label Rename "proportionality to" to "ratio" Feb 29, 2024
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the general changes at first glance but this needs @sbello @cmungall review.. (especially the renaming bit).

I guess it comes down to the question if the new "proportionality to" is really the same in spirit as "ratio" - I hope so :)

@sbello
Copy link
Contributor

sbello commented Mar 7, 2024

I see proportionality to used in the eqs for 4 MP terms (eg.abnormal lymph node cell ratio) these have eqs in the form
'has part' some
('proportionality to' and ('characteristic of' some 'X') and (towards some Y) and ('has modifier' some abnormal))
I think ratio slots into this just fine. Most of the terms use ratio in the label already.

We aren't currently using increased or decreased child terms

The one thing that gives me pause is this part of the comment on the old term "Not all ratios measure proportionality, eg m/s measures velocity which is not a proportion in the sense defined above, it is a quality in its own right." But looking at the definition in both the old and new versions, I think the inclusion of 'the magnitude of another entity' excludes velocity since this involves a single entity.

I think the changes to the definition do not significantly alter the meaning of the term, so I am okay with this change.

@sbello sbello requested review from sbello and removed request for sbello March 7, 2024 15:40
sbello
sbello previously approved these changes Mar 7, 2024
Copy link
Contributor

@sbello sbello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is acceptable (longer comment in conversation)

Copy link
Contributor

@balhoff balhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except one typo.

src/ontology/pato-edit.obo Outdated Show resolved Hide resolved
@ar-ibrahim
Copy link
Collaborator

@rays22 Looks good. I just have a comment on whether the synonyms in the pattern should also reflect 'percentage' terms. For example terms like EFO:0007993 lymphocyte percentage of leukocytes describe a ratio relationship.

@rays22
Copy link
Collaborator Author

rays22 commented Mar 14, 2024

@rays22 Looks good. I just have a comment on whether the synonyms in the pattern should also reflect 'percentage' terms. For example terms like EFO:0007993 lymphocyte percentage of leukocytes describe a ratio relationship.

@ar-ibrahim , In the specific case of EFO:0007993, yes, using the PATIO 'ratio' quality would be appropriate based on this part of the textual definition: ... presented as a ratio, fraction, quotient or percentage.

@rays22
Copy link
Collaborator Author

rays22 commented Mar 14, 2024

Looks good except one typo.

@balhoff ,
Thanks for reviewing this PR and catching the typo. The typo has been fixed in
ad4c591 .

@rays22 rays22 merged commit 42128a5 into master Mar 14, 2024
1 check passed
@rays22 rays22 deleted the issue555 branch March 14, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "ratio" the primary label for PATO:0001470 ! proportionality to
5 participants