Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add repo#show #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chalkos
Copy link
Collaborator

@chalkos chalkos commented Jul 3, 2016

This should fix #3. I tried to implement this based on the comments in that issue.

  • route, controller and view to show pull request information
  • show relevant information for the PRs
  • feedback and discussion

@chalkos
Copy link
Collaborator Author

chalkos commented Jul 3, 2016

It looks like this:
screenshot of google chrome
(all PRs are shown in the screenshot, not just open ones; the actual code only shows open PRs, but I wanted to list more PRs)

@indirect
Copy link
Contributor

indirect commented Jul 4, 2016

This looks like a good start on showing the status of PRs!

I am okay with using the database as a cache, updated whenever new information arrives in a webhook, and updated by polling when needed to refresh the page.

@chalkos
Copy link
Collaborator Author

chalkos commented Jul 5, 2016

I agree with the cache and when to update it. That seems to be a good solution UX-wise.

@chalkos
Copy link
Collaborator Author

chalkos commented Jul 20, 2016

@indirect @segiddins
Could I implement a simple version (without caching and updating information) of this and then later add that functionality? It seems to me like this page is needed, but the extra functionality is not really needed for now.

I would just make all the needed github API requests when loading the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Repo#show
2 participants