Created 717-200 and MD-88

[DeltaJets]

No description provided.

[patsonluk]

Thanks for the proposal! i will probably look at that later this weekend :)

[patsonluk]

O and a quick thing, for consistency, the airplane image will have to be from the template from norebbo.com such as https://www.norebbo.com/2017/06/boeing-717-200-blank-illustration-templates/ and also a trimmed image with transparent background with 500 x 200 px png

Please take this PR from another user for reference : https://github.com/patsonluk/airline/pull/164/files

[DeltaJets]

I know. I just don't want to buy the template.

[patsonluk]

Can you please explain how these 2 new airplane model fill any missing gaps of the existing models in the game? I prefer to add active (in production) models that have some differentiating factors compared to other existing models

As for the template you don't have to buy it. I got approval from norebbo to use their blank template as far as we scale it down to 500 X 200 px. The code would also automatically link back to their website

[DeltaJets]

Sounds good on the template, I'll see what I can do.
The MD88 would fill in as a high capacity low cost plane, which could be used to get airlines off the ground. The 717 would be a step up from the E175 or E190.

[DeltaJets]

Added Norrebbo pictures, not sure if they work. I know the 717 is w/o gear, but I hope we can make an exception.

[DeltaJets]

New one has working links. Need to update the 717 to have gear down but for now I hope it'll do.

[patsonluk]

Hi @DeltaJets thanks for the code contribution. I started looking at the parameters and both of the airplanes are too fuel efficient and too cheap.

If you compare with other models of the same tier u can see they are very overpowered, we will have to adjust that, either make them significantly more expensive or much less fuel efficient. Otherwise it's hard to justify adding them into the game :(

717-200

Model("Boeing 717-200", capacity = 128, fuelBurn = (128 * 3.0).toInt, speed = 811, range = 3820, price = 40000000, lifespan = 35 * 52, constructionTime = 5, countryCode = "US", imageUrl = "https://ibb.co/sHm0FGC/"),

If you compare to

Model("Fokker 100", capacity = 109, fuelBurn = (109 * 3.6).toInt, speed = 845, range = 3170, price = 55000000, lifespan = 30 * 52, constructionTime = 8, countryCode = "NL", imageUrl = "https://www.norebbo.com/2018/07/fokker-100-f-28-0100-blank-illustration-templates/"),
                      Model("Airbus A318", capacity = 132, fuelBurn = (132 * 3).toInt, speed = 829, range = 7800, price = 90000000, lifespan = 35 * 52, constructionTime = 8, countryCode = "NL", imageUrl = "https://www.norebbo.com/2018/01/airbus-a318-blank-illustration-templates-with-pratt-whitney-and-cfm56-engines/"),

you can see that the 717-200 carries more passenger, more fuel efficient, flies further and cheaper than Fokker 100,

Even if it compares to A318, it has same fuel efficiency but at less than half the price.

MD 88

Model("McDonnell Douglas MD-88", capacity = 172, fuelBurn = (172 * 3.5).toInt, speed = 925, range = 4720, price = 45000000, lifespan = 35 * 52, constructionTime = 6, countryCode = "US", imageUrl = "https://ibb.co/26pVBYN/"),

Compare to

Model("McDonnel Douglas MD-90", capacity = 160, fuelBurn = (160 * 3.55).toInt, speed = 811, range = 3787, price = 80000000, lifespan = 30 * 52, constructionTime = 18, countryCode = "US", imageUrl = "https://www.norebbo.com/2018/02/mcdonnell-douglas-md-90-blank-illustration-templates/"),
                      Model("Boeing 737-800", capacity = 184, fuelBurn = (184 * 3.8).toInt, speed = 825, range = 5436, price = 100000000, lifespan = 35 * 52, constructionTime = 24, countryCode = "US", imageUrl = "https://www.norebbo.com/2012/11/boeing-737-800-blank-illustration-templates/"),

Similarly it's way more powerful than MD-90/MD-88 and at almost only half the price

As for the Pull Request, please follow the format of https://github.com/patsonluk/airline/pull/164/files which

1. Instead of submitting a new file, you should modify the existing airline-data/src/main/scala/com/patson/model/airplane/Model.scala and submit that change
2. Instead of providing a link to a cropped image, you should commit the actual image file as a part of the pull request
3. The link in the model should be pointing directly to Norebbo.com such as https://www.norebbo.com/2019/03/embraer-e195-e2-side-view/

Please let me know if you have further questions!

[DeltaJets]

Yeah. I can no longer access Norebbo, so that's that. I can modify the planes to make them a bit pricier and less efficient.

[DeltaJets]

Alright. The final one! (I hope.)
Changes:
Increased price of both models, decreased efficiency.
Issues and a question:
I can no longer access Norebbo, because I use a school device and they blocked it. (Jerks.)
So my question to you is: Can you merge this and then edit it so that the image links point to Norebbo? Also... If you don't mind having a look at my other planes that would be great. We don't have to implement them, they kinda suck, but I was just doing them for practice.