-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 747-8I, longer range and better efficiency than 747-400 #258
base: master
Are you sure you want to change the base?
Conversation
@DuploMinh Thanks for the contribution! I apologize that we do not have very good documentation on how to add new airplanes! For a complete example please refer to https://github.com/patsonluk/airline/pull/165/files We basically need to have the actual trimmed and scaled airplane images (see that PR for the dimension) with transparent background from https://www.norebbo.com/ . I have an agreement with the owner of that website to use his images for the game but it has to be scaled down to certain dimension Besides, we have frozen addition of airplanes for current version. But don't worry, we will need alot of new airplanes for V1.2 - which we will add a long list of airplanes sort by each series. Are you interested in helping out with the V1.2? The details are in : |
Do I have to purchase the images? |
You shouldn't need to since we are not getting the source. You can get the image from like https://www.norebbo.com/wp-content/uploads/2019/12/777-8_white-778x445.jpg But then would require some photo editing - i use gimp
|
…ge and added wingspan info to aircrafts.
@DuploMinh also one more thing, in the future can u please separate out the changes. For example having the wingspan change as one PR and then the PR is for adding 747-8I either as a separate PR or another PR that builds on top fo the wingspan changes? :) It keeps things in cleaner states that separate the concerns, so we can have the option to merge the wingspan change earlier while giving us more time to review the new airplane model changes. It's probably okay to keep this PR as is right now :) But any future new model additions i would recommend having a separate branch/PR that base on this PR We dun really have to create tiny PR for every single new model changes, and it's definitely okay if the new airplane additional all goes in as a single PR. But for changes that are quite different in nature (for example add new wingspan vs adding new airplane), it's nicer if they are in different PR |
Sorry, I am pretty new to git overall. I didn't want to merge the wingspan one since it is very much work in progress. I just found out about this. |
Added image for A350-900ulr and B747-8i
I created 747-8I for to be a more fuel efficient and longer range version of 747-400. I might also consider adding A350-900ULR as there is so far no ULR plane modeled.