addressing feedback

patternfly-extension-testing · Oct 25, 2023 · e294bba · e294bba
1 parent 67e4b8e
commit e294bba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/demo-app-ts/src/components/StyleGroup.tsx b/packages/demo-app-ts/src/components/StyleGroup.tsx
@@ -84,7 +84,6 @@ const StyleGroup: React.FunctionComponent<StyleGroupProps> = ({
       collapsedWidth={collapsedWidth}
       collapsedHeight={collapsedHeight}
       showLabel={detailsLevel === ScaleDetailsLevel.high}
-      hulledOutline={true}
       {...rest}
       {...passedData}
     >

diff --git a/packages/module/src/components/groups/DefaultGroupExpanded.tsx b/packages/module/src/components/groups/DefaultGroupExpanded.tsx
@@ -99,7 +99,7 @@ const DefaultGroupExpanded: React.FunctionComponent<DefaultGroupExpandedProps> =
   labelIcon,
   labelIconPadding,
   onCollapseChange,
-  hulledOutline,
+  hulledOutline = true,
 }) => {
   const [hovered, hoverRef] = useHover();
   const [labelHover, labelHoverRef] = useHover();
@@ -111,7 +111,6 @@ const DefaultGroupExpanded: React.FunctionComponent<DefaultGroupExpandedProps> =
   const labelLocation = React.useRef<PointWithSize>();
   const pathRef = React.useRef<string>();
   const boxRef = React.useRef<Rect | null>(null);
-  const nodeElement = element as Node;
 
   let parent = element.getParent();
   let altGroup = false;
@@ -160,7 +159,7 @@ const DefaultGroupExpanded: React.FunctionComponent<DefaultGroupExpandedProps> =
       // Compute the location of the group label.
       labelLocation.current = computeLabelLocation(hullPoints as PointWithSize[]);
     } else {
-      boxRef.current = nodeElement.getBounds();
+      boxRef.current = element.getBounds();
       labelLocation.current = [boxRef.current.x + boxRef.current.width / 2, boxRef.current.y + boxRef.current.height, 0];
     }
   }