fix: remove redundant aria-describedby attributes (#243)

* fix: remove redundant aria-describedby attributes * Update packages/module/src/ResponseActions/ResponseActionButton.tsx Co-authored-by: Rebecca Alpert <[email protected]> --------- Co-authored-by: Rebecca Alpert <[email protected]>
patternfly · Oct 16, 2024 · 6ea3950 · 6ea3950
1 parent 3741773
commit 6ea3950
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 9 deletions.
diff --git a/packages/module/src/ChatbotHeader/ChatbotHeaderMenu.tsx b/packages/module/src/ChatbotHeader/ChatbotHeaderMenu.tsx
@@ -25,7 +25,6 @@ export const ChatbotHeaderMenu: React.FunctionComponent<ChatbotHeaderMenuProps>
       <Button
         className="pf-chatbot__button--toggle-menu"
         variant="plain"
-        aria-describedby="pf-chatbot__tooltip--toggle-menu"
         onClick={onMenuToggle}
         aria-label={menuAriaLabel}
         icon={

diff --git a/packages/module/src/Message/CodeBlockMessage/CodeBlockMessage.tsx b/packages/module/src/Message/CodeBlockMessage/CodeBlockMessage.tsx
@@ -54,7 +54,6 @@ const CodeBlockMessage = ({ children, className, ...props }: JSX.IntrinsicElemen
           aria-label="Copy code button"
           variant="plain"
           className="pf-chatbot__button--copy"
-          aria-describedby={tooltipID}
           onClick={(event) => handleCopy(event, children)}
         >
           {copied ? <CheckIcon /> : <CopyIcon />}

diff --git a/packages/module/src/MessageBar/AttachButton.tsx b/packages/module/src/MessageBar/AttachButton.tsx
@@ -55,7 +55,6 @@ const AttachButtonBase: React.FunctionComponent<AttachButtonProps> = ({
           variant="plain"
           ref={innerRef}
           className={`pf-chatbot__button--attach ${className ?? ''}`}
-          aria-describedby="pf-chatbot__tooltip--attach"
           aria-label={props['aria-label'] || 'Attach Button'}
           isDisabled={isDisabled}
           onClick={onClick ?? open}

diff --git a/packages/module/src/MessageBar/MicrophoneButton.tsx b/packages/module/src/MessageBar/MicrophoneButton.tsx
@@ -95,7 +95,6 @@ export const MicrophoneButton: React.FunctionComponent<MicrophoneButtonProps> =
       <Button
         variant="plain"
         className={`pf-chatbot__button--microphone ${isListening ? 'pf-chatbot__button--microphone--active' : ''} ${className ?? ''}`}
-        aria-describedby="pf-chatbot__tooltip--use-microphone"
         aria-label={props['aria-label'] || 'Microphone Button'}
         onClick={isListening ? stopListening : startListening}
         icon={

diff --git a/packages/module/src/MessageBar/SendButton.tsx b/packages/module/src/MessageBar/SendButton.tsx
@@ -36,7 +36,6 @@ export const SendButton: React.FunctionComponent<SendButtonProps> = ({
     <Button
       className={`pf-chatbot__button--send ${className ?? ''}`}
       variant="link"
-      aria-describedby="pf-chatbot__tooltip--send"
       aria-label={props['aria-label'] || 'Send Button'}
       onClick={onClick}
       icon={

diff --git a/packages/module/src/MessageBox/JumpButton.tsx b/packages/module/src/MessageBox/JumpButton.tsx
@@ -25,7 +25,6 @@ const JumpButton: React.FunctionComponent<JumpButtonProps> = ({ position, isHidd
         variant="plain"
         className={`pf-chatbot__jump pf-chatbot__jump--${position} ${isHidden && `pf-chatbot__jump--${position}--hidden`}`}
         aria-label={`Jump ${position} button`}
-        aria-describedby={`pf-chatbot__tooltip--jump-${position}`}
         onClick={onClick}
       >
         <Icon iconSize="xl" isInline>

diff --git a/packages/module/src/ResponseActions/ResponseActionButton.tsx b/packages/module/src/ResponseActions/ResponseActionButton.tsx
@@ -2,7 +2,7 @@ import React from 'react';
 import { Button, Icon, Tooltip, TooltipProps } from '@patternfly/react-core';
 
 export interface ResponseActionButtonProps {
-  /** Aria-label for the button */
+  /** Aria-label for the button. Defaults to the value of the tooltipContent if none provided */
   ariaLabel?: string;
   /** Icon for the button */
   icon: React.ReactNode;
@@ -40,8 +40,7 @@ export const ResponseActionButton: React.FunctionComponent<ResponseActionButtonP
     <Button
       variant="plain"
       className={`pf-chatbot__button--response-action ${className ?? ''}`}
-      aria-describedby={`pf-chatbot__tooltip-response-action-${tooltipContent}`}
-      aria-label={ariaLabel}
+      aria-label={ariaLabel || tooltipContent}
       icon={
         <Icon isInline size="lg">
           {icon}