Handle key press of the input #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow to send the messages when pressing enter key - Behaves like it does on chat clients, pressing shift + enter will jump to the next line instead of sending the message - Adding tests
fhlavac
approved these changes
Jul 6, 2024
|
🎉 This PR is included in version 1.0.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing this functionality in the extension, basically being able to press Enter key to send a message.
I was thinking whether we should pass the keypress handler and do it from our virtual assistant or in the extension.
Since this is a similar functionality as other chat clients, it makes sense to have it here directly.
I didn't add any way to override, but if we feel that this is a need in the future we could accept the keypress handler.