feat(Settings): Add settings layout #360
Conversation
|
Preview: https://chatbot-pr-chatbot-360.surge.sh A11y report: https://chatbot-pr-chatbot-360-a11y.surge.sh |
rebeccaalpert
force-pushed
the
settings
branch
from
11154a2 to
bfe5c87
Compare
rebeccaalpert
force-pushed
the
settings
branch
4 times, most recently
from
0466ab9 to
7907f99
Compare
rebeccaalpert
changed the title
|
They should be able to fill in whatever they would like! I can add this to the demo if you'd like it in there though. |
There was a problem hiding this comment.
A side thought that I had (which isn't a blocker) is if we should add one of the "back to bottom" buttons to the default overlay display?
Just because I couldn't initially tell that there were more items to scroll to, due to the scroll bar only appearing once you start scrolling:
Kind of a small thing that may not actually be a confusion for any real users, but thought I'd mention it to see thoughts/in case it's not a difficult add!
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/UI.md
Outdated
Show resolved
Hide resolved
Let's add a scroll bar that shows on default if there is extra items |
rebeccaalpert
force-pushed
the
settings
branch
2 times, most recently
from
b18c96b to
0bd86b1
Compare
|
Scroll bar added @kaylachumley @edonehoo! |
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/Settings.tsx
Outdated
Show resolved
Hide resolved
| tooltipContent = 'Close' | ||
| }: ChatbotHeaderCloseButtonProps) => ( | ||
| <div className={`pf-chatbot__menu ${className}`}> | ||
| <Tooltip content={tooltipContent} position="bottom" {...tooltipProps}> |
There was a problem hiding this comment.
Is it necessary to deliver a whole new close button component? what about this one is different than other buttons?
There was a problem hiding this comment.
I think Kayla and the Lightspeeds might want a close button for the general chatbot if they're going to be toggling it from other locations. This way it can be used for Settings or in the main chatbot itself. We don't have a universal chatbot button yet that incorporates all the header button styles - I'd want to do that maybe as we have time.
rebeccaalpert
force-pushed
the
settings
branch
from
0bd86b1 to
6bb1132
Compare
rebeccaalpert
force-pushed
the
settings
branch
from
6bb1132 to
074b5e6
Compare
|
🎉 This PR is included in version 2.2.0-prerelease.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Stuck this as a separate component within the chatbot: https://chatbot-pr-chatbot-360.surge.sh/patternfly-ai/chatbot/ui/react/settings/
Docs: https://chatbot-pr-chatbot-360.surge.sh/patternfly-ai/chatbot/ui/#settings
I added a dropdown that can also toggle it, but unsure if we want other stuff in this demo. I know Nicole generally wants them simple, but we don't have any guidelines for this yet.