feat(ResponseActions): Add click state #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://chatbot-pr-chatbot-382.surge.sh A11y report: https://chatbot-pr-chatbot-382-a11y.surge.sh |
rebeccaalpert
force-pushed
the
response-action-clicked
branch
3 times, most recently
from
d39d4ea to
ef0b576
Compare
edonehoo
requested changes
Dec 13, 2024
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/Messages.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/Messages.md
Show resolved
Hide resolved
rebeccaalpert
force-pushed
the
response-action-clicked
branch
from
26e9dab to
91d345f
Compare
Add click state to response actions block. The last currently selected item will remain selected. Clients can also pass in custom tooltips or aria labels based on the clicked state.
…mples/Messages/Messages.md Co-authored-by: Erin Donehoo <[email protected]>
rebeccaalpert
force-pushed
the
response-action-clicked
branch
from
91d345f to
64633dc
Compare
nicolethoen
reviewed
Dec 17, 2024
There was a problem hiding this comment.
The screen reader is not capturing the change in the aria-label after clicking the button.
I believe you need to use an aria-live attribute in this case per this guidance: https://www.patternfly.org/components/tooltip/accessibility#aria-live
|
Just added; thank you for catching! |
nicolethoen
approved these changes
Dec 17, 2024
|
🎉 This PR is included in version 2.2.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add click state to response actions block. The last currently selected item will remain selected until you click someone else on the screen. Clients can also pass in custom tooltips or aria labels based on the clicked state.
Docs:
I've been working directly with Kayla on these already - she has seen them.