Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-31243 add system message entry #9

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

aferd
Copy link
Contributor

@aferd aferd commented Apr 1, 2024

@patternfly-build
Copy link

patternfly-build commented Apr 1, 2024

@aferd aferd marked this pull request as draft April 2, 2024 13:41
@fhlavac
Copy link
Collaborator

fhlavac commented Apr 3, 2024

@aferd if this one gets merged after #11 could you please add a test case for your part?

@aferd aferd marked this pull request as ready for review April 3, 2024 14:52
@aferd aferd requested a review from josejulio April 3, 2024 16:40
return (
<TextContent>
<Text component={TextVariants.small} className={classes.systemMessageText}>
{props.text} {props.href}
Copy link
Collaborator

@josejulio josejulio Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could just use {props.children} here. (You would need to add to the props as in here)

@josejulio
Copy link
Collaborator

Looks like there is a minor conflict, could you fix it?

Copy link
Collaborator

@josejulio josejulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@josejulio josejulio requested a review from epwinchell April 3, 2024 19:19
@epwinchell epwinchell merged commit 5b67cbb into patternfly:main Apr 3, 2024
5 checks passed
Copy link

🎉 This PR is included in version 1.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants