Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tokens): get latest from figma #76

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Jul 11, 2024

fixes #75

the deets:

  • fixes the line-heights for body/heading text
  • adds --default to the font-weight tokens
  • pulls in --[body/heading]--bold font-weight tokens
  • enables corepack w/ yarn 1.x via corepack use [email protected]
  • adds a yarn build:scss:core script that runs yarn build:scss -s '@mixin pf-v6-tokens', the job we run to build tokens that core can consume

@mcoker mcoker requested review from evwilkin and lboehling July 11, 2024 17:09
@mcoker mcoker requested a review from srambach July 12, 2024 15:41
Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -12,6 +12,7 @@
"build:docs": "yarn workspace @patternfly/design-tokens docs:build",
"build:fed:packages": "yarn workspace @patternfly/design-tokens build:fed:packages",
"build:scss": "yarn workspace @patternfly/design-tokens build:scss",
"build:scss:core": "yarn build:scss -s '@mixin pf-v6-tokens'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@srambach srambach merged commit f537626 into patternfly:main Jul 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some font-weight tokens are not being exported
3 participants