Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add value for color tokens where missing #85

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

evwilkin
Copy link
Member

@evwilkin evwilkin commented Sep 4, 2024

Closes #84

This PR adds an expandable row for color tokens without references in order to still have a way to view the resolved color value of the token. Currently the preview swatch displays the color, but the table does not actually list the value of the color for these tokens.

@evwilkin
Copy link
Member Author

evwilkin commented Sep 9, 2024

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🔴 🟢 ⚪

@evwilkin evwilkin merged commit 86d92bb into patternfly:main Oct 17, 2024
3 checks passed
@evwilkin evwilkin deleted the chore/84-color-tokens branch October 17, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(docs): color tokens don't always show computed value
3 participants