Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): updated scroll selector for jumplinks, router links #4197

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

evwilkin
Copy link
Member

@evwilkin evwilkin commented Aug 15, 2024

Closes #4085

Related to patternfly/patternfly-react#10860 - scroll selector needed to be updated due to new wrapper component.

This PR updates the scrollable element passed to JumpLinks in the Table of Contents component, as well as references in the Link component (triggers scroll to top of page after link click), to .pf-v6-c-page__main-container, fixing:

  • Scrollspy not working (active jumplink in the table of contents doesn't change as you scroll page)
  • Scrolling down one page then navigating to another page does not scroll back to the top of new page

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 15, 2024

@evwilkin evwilkin requested a review from mcoker August 15, 2024 19:18
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot! Looks great now 🥳

@evwilkin evwilkin merged commit f5de805 into patternfly:v6 Aug 20, 2024
4 checks passed
@evwilkin evwilkin deleted the fix/4085-scrolling branch August 20, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants