Merge pull request #274 from patternfly/v4-update-showdown

fix(deps): Remove showdown as dependency
patternfly · Oct 30, 2023 · cc8558f · cc8558f
2 parents 31c78ca + 41c230a
commit cc8558f
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 10 deletions.
diff --git a/packages/dev/package.json b/packages/dev/package.json
@@ -22,7 +22,7 @@
     "react-dom": "^16.14.0",
     "react-i18next": "^11.7.3",
     "react-router-dom": "^5.2.0",
-    "showdown": "1.8.6",
+    "showdown": "2.1.0",
     "lodash-es": "^4.17.21"
   },
   "devDependencies": {

diff --git a/packages/module/package.json b/packages/module/package.json
@@ -48,13 +48,12 @@
     "@patternfly/react-core": ">=4.115.2",
     "react": ">=16.8.0",
     "react-dom": ">=16.8.0",
-    "showdown": ">=1.8.6"
+    "showdown": ">=2.1.0"
   },
   "dependencies": {
     "@patternfly/react-catalog-view-extension": "^4.93.15",
     "dompurify": "^2.2.6",
-    "history": "^5.0.0",
-    "showdown": "1.8.6"
+    "history": "^5.0.0"
   },
   "devDependencies": {
     "@patternfly/documentation-framework": "^1.8.0",

diff --git a/packages/module/rollup.config.js b/packages/module/rollup.config.js
@@ -73,7 +73,7 @@ export const esBuild = {
 };
 
 // Build out the full version of quick starts including the dependencies
-// (showdown, PatternFly, ...)
+// (PatternFly, ...)
 // This is useful also for evaluating the CSS against so we can remove unused styles
 const esBuildWithDeps = {
   input: 'src/index.ts',

diff --git a/yarn.lock b/yarn.lock
@@ -4630,6 +4630,11 @@ commander@^7.0.0, commander@~7.2.0:
   resolved "https://registry.yarnpkg.com/commander/-/commander-7.2.0.tgz#a36cb57d0b501ce108e4d20559a150a391d97ab7"
   integrity sha512-QrWXB+ZQSVPmIWIhtEO9H+gwHaMGYiF5ChvoJ+K9ZGHG/sVsa6yiesAD1GC/x46sET00Xlwo1u49RVVVzvcSkw==
 
+commander@^9.0.0:
+  version "9.5.0"
+  resolved "https://registry.yarnpkg.com/commander/-/commander-9.5.0.tgz#bc08d1eb5cedf7ccb797a96199d41c7bc3e60d30"
+  integrity sha512-KRs7WVDKg86PWiuAqhDrAQnTXZKraVcCc6vFdL14qrZ/DcWwuRo7VoiYXalXO7S5GKpqYiVEwCbgFDfxNHKJBQ==
+
 common-log-format@~0.1.3:
   version "0.1.4"
   resolved "https://registry.yarnpkg.com/common-log-format/-/common-log-format-0.1.4.tgz#39ba6ccb5c46c2f89aa92f232866d18f18075ba9"
@@ -14258,12 +14263,12 @@ shortid@^2.2.8:
   dependencies:
     nanoid "^2.1.0"
 
-showdown@1.8.6:
-  version "1.8.6"
-  resolved "https://registry.yarnpkg.com/showdown/-/showdown-1.8.6.tgz#91ea4ee3b7a5448aaca6820a4e27e690c6ad771c"
-  integrity sha1-kepO47elRIqspoIKTifmkMatdxw=
+showdown@2.1.0:
+  version "2.1.0"
+  resolved "https://registry.yarnpkg.com/showdown/-/showdown-2.1.0.tgz#1251f5ed8f773f0c0c7bfc8e6fd23581f9e545c5"
+  integrity sha512-/6NVYu4U819R2pUIk79n67SYgJHWCce0a5xTP979WbNp0FL9MN1I1QK662IDU1b6JzKTvmhgI7T7JYIxBi3kMQ==
   dependencies:
-    yargs "^10.0.3"
+    commander "^9.0.0"
 
 side-channel@^1.0.4:
   version "1.0.4"