Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styling for v6 #303

Merged
merged 11 commits into from
Jul 26, 2024
Merged

Update styling for v6 #303

merged 11 commits into from
Jul 26, 2024

Conversation

jessiehuff
Copy link
Collaborator

@jessiehuff jessiehuff commented Jun 14, 2024

@nicolethoen nicolethoen linked an issue Jun 24, 2024 that may be closed by this pull request
@andrew-ronaldson
Copy link
Contributor

Not sure if there have been conversations about this yet but we have a blue header in Figma for the drawer.
Screenshot 2024-07-05 at 9 05 07 AM

@nicolethoen
Copy link
Contributor

@andrew-ronaldson I don't think it's made it to core/react yet. I can link to any issues that get created in a quickstarts follow up issue to make sure we use it once it exists.

@andrew-ronaldson
Copy link
Contributor

Could we make this drawer header in quickstarts using tokens if I put it together?

@nicolethoen
Copy link
Contributor

@andrew-ronaldson I took a stab at identifying appropriate tokens to get it running. I updated the preview links at the top of this PR. LMK what you think! :)

@andrew-ronaldson
Copy link
Contributor

Looks good but we'll need a follow up issue for some bugs. Adding here but I'll put them in another issue if they can't be addressed for Beta. @lboehling do you have any other thoughts on this?

The cards don't seem to have a hover or clicked state applied.
Screenshot 2024-07-17 at 10 41 10 AM

The quickstart header needs a bit more padding, please
Screenshot 2024-07-17 at 10 43 36 AM

Looks like the step titles are using var(--pf-t--global--font--family--heading) but in Figma it is

font-family: var(--pf-t--global--font--family--body);
font-weight: var(---pf-t--global--font--weight--body--bold);
font-size: var(--pf-t--global--font--size--body--large);

Copy link
Contributor

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thing of beauty! Thanks @nicolethoen

@dlabaj dlabaj merged commit 1647f3a into patternfly:v6 Jul 26, 2024
3 checks passed
Copy link

🎉 This PR is included in version 6.0.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 6.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update styling for V6
5 participants