-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update styling for v6 #303
Conversation
@andrew-ronaldson I don't think it's made it to core/react yet. I can link to any issues that get created in a quickstarts follow up issue to make sure we use it once it exists. |
Could we make this drawer header in quickstarts using tokens if I put it together? |
@andrew-ronaldson I took a stab at identifying appropriate tokens to get it running. I updated the preview links at the top of this PR. LMK what you think! :) |
Looks good but we'll need a follow up issue for some bugs. Adding here but I'll put them in another issue if they can't be addressed for Beta. @lboehling do you have any other thoughts on this? The cards don't seem to have a hover or clicked state applied. The quickstart header needs a bit more padding, please Looks like the step titles are using var(--pf-t--global--font--family--heading) but in Figma it is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A thing of beauty! Thanks @nicolethoen
🎉 This PR is included in version 6.0.0-alpha.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #299
preview docs: https://qs-design-update-docs.surge.sh/extensions/quick-starts
preview demo: https://qs-design-update.surge.sh/