fix(JumpLinks) jump links dont work after skipToContent (#9360)

* fix(JumpLinks) jump links dont work after skipToContent * Updated conditional for refreshing newScrollItems --------- Co-authored-by: Eric Olkowski <[email protected]>
patternfly · Aug 22, 2023 · 95ecf33 · 95ecf33
1 parent dab64bb
commit 95ecf33
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/react-core/src/components/JumpLinks/JumpLinks.tsx b/packages/react-core/src/components/JumpLinks/JumpLinks.tsx
@@ -114,11 +114,15 @@ export const JumpLinks: React.FunctionComponent<JumpLinksProps> = ({
     const scrollPosition = Math.ceil(scrollableElement.scrollTop + offset);
     window.requestAnimationFrame(() => {
       let newScrollItems = scrollItems;
-      // Items might have rendered after this component. Do a quick refresh.
-      if (!newScrollItems[0] || newScrollItems.includes(null)) {
+      // Items might have rendered after this component or offsetTop values may need
+      // to be updated. Do a quick refresh.
+      const requiresRefresh =
+        newScrollItems.every((e) => !e?.offsetTop) || !newScrollItems[0] || newScrollItems.includes(null);
+      if (requiresRefresh) {
         newScrollItems = getScrollItems(children, []);
         setScrollItems(newScrollItems);
       }
+
       const scrollElements = newScrollItems
         .map((e, index) => ({
           y: e ? e.offsetTop : null,