Updated tests per Austin feedback

patternfly · Jan 24, 2024 · d7cb7b1 · d7cb7b1
1 parent a658ca3
commit d7cb7b1
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx b/packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx
@@ -33,7 +33,7 @@ test('Renders custom className', () => {
 test('Does not render screen reader text by default', () => {
   render(<HelperTextItem>help test text 1</HelperTextItem>);
 
-  expect(screen.queryByText('help test text 1')?.querySelector('.pf-v5-screen-reader')).not.toBeInTheDocument();
+  expect(screen.queryByText('status')).not.toBeInTheDocument();
 });
 
 Object.values(['indeterminate', 'warning', 'success', 'error']).forEach((variant) => {
@@ -52,10 +52,21 @@ Object.values(['indeterminate', 'warning', 'success', 'error']).forEach((variant
         text
       </HelperTextItem>
     );
-    expect(screen.getByText('text').querySelector('span')).toHaveTextContent(`: ${variant} status;`);
+    expect(screen.getByText(`: ${variant} status;`)).toBeInTheDocument();
   });
 });
 
+test('Renders custom screen reader text', () => {
+  render(
+    <HelperTextItem variant="error" screenReaderText="danger">
+      help test text 1
+    </HelperTextItem>
+  );
+
+  expect(screen.queryByText(': error status;')).not.toBeInTheDocument();
+  expect(screen.getByText(': danger;')).toBeInTheDocument();
+});
+
 test('Renders id when id is passed', () => {
   render(<HelperTextItem id="text-item">help test text 1</HelperTextItem>);
   expect(screen.getByText('help test text 1').parentElement).toHaveAttribute('id', 'text-item');