Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification drawer item - no offset prop for action(s) #10715

Closed
mcoker opened this issue Jul 9, 2024 · 0 comments · Fixed by #10822
Closed

Notification drawer item - no offset prop for action(s) #10715

mcoker opened this issue Jul 9, 2024 · 0 comments · Fixed by #10822
Assignees

Comments

@mcoker
Copy link
Contributor

mcoker commented Jul 9, 2024

Follow up to core PR - patternfly/patternfly#6854

By default, the notification drawer item action has been offset vertically by the value of a button's top padding, which aligns the icon/text in a plain button with the notification item's header text/title. We added a class .pf-m-no-offset that goes on the list-item-action element. FWIW we have the same modifier for cards and hints.

Since actions are passed as children to <NotificationDrawerListItemHeader>, I'm guessing we might add an actionHasNoOffset prop that renders the .pf-m-no-offset class?

{children && <div className={css(styles.notificationDrawerListItemAction)}>{children}</div>}

I don't think this needs to go in for beta, and technically wouldn't even have to be in the release for v6 since it isn't breaking to add, though since we changed the default layout for v6, it would be good to give users an opt-in to the old layout with the v6 release if possible.

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jul 9, 2024
@tlabaj tlabaj moved this from Needs triage to On deck in PatternFly Issues Jul 23, 2024
@tlabaj tlabaj added this to the Penta final release milestone Jul 23, 2024
@kmcfaul kmcfaul self-assigned this Jul 25, 2024
@kmcfaul kmcfaul moved this from On deck to Not started in PatternFly Issues Jul 29, 2024
@kmcfaul kmcfaul moved this from Not started to In Progress in PatternFly Issues Jul 30, 2024
@kmcfaul kmcfaul linked a pull request Jul 30, 2024 that will close this issue
@kmcfaul kmcfaul moved this from In Progress to PR Review in PatternFly Issues Jul 30, 2024
@kmcfaul kmcfaul closed this as completed Aug 21, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants