You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By default, the notification drawer item action has been offset vertically by the value of a button's top padding, which aligns the icon/text in a plain button with the notification item's header text/title. We added a class .pf-m-no-offset that goes on the list-item-action element. FWIW we have the same modifier for cards and hints.
Since actions are passed as children to <NotificationDrawerListItemHeader>, I'm guessing we might add an actionHasNoOffset prop that renders the .pf-m-no-offset class?
I don't think this needs to go in for beta, and technically wouldn't even have to be in the release for v6 since it isn't breaking to add, though since we changed the default layout for v6, it would be good to give users an opt-in to the old layout with the v6 release if possible.
The text was updated successfully, but these errors were encountered:
Follow up to core PR - patternfly/patternfly#6854
By default, the notification drawer item action has been offset vertically by the value of a button's top padding, which aligns the icon/text in a plain button with the notification item's header text/title. We added a class
.pf-m-no-offset
that goes on the list-item-action element. FWIW we have the same modifier for cards and hints.Since actions are passed as children to
<NotificationDrawerListItemHeader>
, I'm guessing we might add anactionHasNoOffset
prop that renders the.pf-m-no-offset
class?patternfly-react/packages/react-core/src/components/NotificationDrawer/NotificationDrawerListItemHeader.tsx
Line 106 in cb10980
I don't think this needs to go in for beta, and technically wouldn't even have to be in the release for v6 since it isn't breaking to add, though since we changed the default layout for v6, it would be good to give users an opt-in to the old layout with the v6 release if possible.
The text was updated successfully, but these errors were encountered: