Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NotificationDrawer): add no offset prop #10822

Merged
merged 2 commits into from
Aug 21, 2024
Merged

feat(NotificationDrawer): add no offset prop #10822

merged 2 commits into from
Aug 21, 2024

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jul 30, 2024

What: Closes #10715

  • Adds actionHasNoOffset property.
  • Adds tests for new prop.

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 30, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-10822.surge.sh

A11y report: https://patternfly-react-pr-10822-a11y.surge.sh

@kmcfaul kmcfaul linked an issue Jul 30, 2024 that may be closed by this pull request
Notification drawer item - no offset prop for action(s) #10715
Closed
@tlabaj tlabaj requested review from a team and mattnolting and removed request for a team August 1, 2024 18:40
tlabaj
tlabaj approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlabaj tlabaj requested review from a team, wise-king-sullyman and thatblindgeye and removed request for a team and wise-king-sullyman August 1, 2024 18:44
mattnolting
mattnolting approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kmcfaul kmcfaul force-pushed the notidrawer-offset branch from 8b2e38d to d36cc7d Compare August 12, 2024 14:18
@tlabaj tlabaj merged commit 2ac50fe into patternfly:v6 Aug 21, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlabaj tlabaj tlabaj approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@mattnolting mattnolting mattnolting approved these changes

@thatblindgeye thatblindgeye Awaiting requested review from thatblindgeye thatblindgeye was automatically assigned from patternfly/react-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification drawer item - no offset prop for action(s)
5 participants
@kmcfaul @patternfly-build @mattnolting @wise-king-sullyman @tlabaj