Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expandable section - update to use <Button> for toggle #10878

Closed
mcoker opened this issue Aug 22, 2024 · 0 comments · Fixed by #10891
Closed

Expandable section - update to use <Button> for toggle #10878

mcoker opened this issue Aug 22, 2024 · 0 comments · Fixed by #10891
Assignees

Comments

@mcoker
Copy link
Contributor

mcoker commented Aug 22, 2024

Follow up to core PR - patternfly/patternfly#7000

TL;DR of the updates:

  • Replace the custom button in expandableToggle with a <Button variant="link">
    • Move all of the logic that was on the custom button to the new <Button>
  • Wrap the expandableToggle in <div className={css(styles.expandableSectionToggle)}>

Some more details:

@mcoker mcoker added this to the Penta final release milestone Aug 22, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Aug 22, 2024
@mcoker mcoker moved this from Needs triage to Not started in PatternFly Issues Aug 22, 2024
@tlabaj tlabaj self-assigned this Aug 22, 2024
@kmcfaul kmcfaul moved this from Not started to In Progress in PatternFly Issues Aug 27, 2024
@tlabaj tlabaj linked a pull request Aug 28, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in PatternFly Issues Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants